[rocRAND][Code Coverage] Increase rocRAND code coverage#173
Closed
NguyenNhuDi wants to merge 14 commits into
Closed
[rocRAND][Code Coverage] Increase rocRAND code coverage#173NguyenNhuDi wants to merge 14 commits into
NguyenNhuDi wants to merge 14 commits into
Conversation
NguyenNhuDi
requested review from
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
umfranzw
pushed a commit
to umfranzw/rocm-libraries
that referenced
this pull request
Jun 10, 2025
[ROCm/hipRAND commit: 2809d67]
…rease-code-coverage-rs-7.0
umfranzw
requested changes
Jun 23, 2025
Contributor
umfranzw
left a comment
umfranzw
left a comment
There was a problem hiding this comment.
I think this looks good, I just have a few minor comments.
| { \ | ||
| std::cerr << "Encountered ROCRAND error: " << status << "at line" << __LINE__ \ | ||
| << " in file " << __FILE__ << "\n"; \ | ||
| exit(-1); \ |
Contributor
There was a problem hiding this comment.
Since we know the error here (status), could we pass that to exit instead of -1?
Eg. exit(status)?
Contributor
Author
There was a problem hiding this comment.
Yes I believe we could. I will update this
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Contributor
Author
|
Closing to rebase to develop on pr #409 |
NguyenNhuDi
added a commit
that referenced
this pull request
Jul 14, 2025
This PR is recreated to merge into develop instead of release staging branch. Previous PR is #173.
NguyenNhuDi
added a commit
to NguyenNhuDi/rocm-libraries
that referenced
this pull request
Jul 18, 2025
This PR is recreated to merge into develop instead of release staging branch. Previous PR is ROCm#173.
shahamed
pushed a commit
that referenced
this pull request
Jul 19, 2025
This PR is recreated to merge into develop instead of release staging branch. Previous PR is #173.
eidenyoshida
pushed a commit
that referenced
this pull request
Jul 25, 2025
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Cleanup frontend POC graph and node attribute access patterns * Pointwise node use getters * Uncomment
ammallya
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Cleanup frontend POC graph and node attribute access patterns * Pointwise node use getters * Uncomment [ROCm/hipDNN commit: a7a5ab5]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.