Skip to content

Revert "remove options --no-enumerate (#966)" #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+3 −0
Closed

Revert "remove options --no-enumerate (#966)" #1558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions shared/tensile/Tensile/cmake/TensileConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,9 @@ function(TensileCreateLibraryFiles
set(Options ${Options} "--architecture=${archString}")
endif()

# We do not need to do device enumeration at library build time.
set(Options ${Options} "--no-enumerate")

Comment on lines +218 to +220
Copy link
Contributor

@TorreZuk TorreZuk Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't follow the other code pattern for options so probably better to wrap in a control option, e.g.
if (NOT Tensile_ENUMERATE).
"We do not..." is too ambiguous, state your use case which I presume is build only on possibly a CPU only node. This function may bey used by other community members with build and benchmark pattern.

Copy link
Contributor

@stellaraccident stellaraccident Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The library build path does build on a CPU-only node without any AMD software installed (drivers, ROCm or otherwise). If there are other use cases hitting this path, then it needs better isolation. It would seem to not just be "community" paths, though, since we failed something in one of our own flows.

Copy link
Contributor

@TorreZuk TorreZuk Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just want the comment in the code improved and cmake control var for older default build for benchmarking. Working on revisions that will allow this PR to merge #1636

set(CommandLine ${Script} ${Options} ${Tensile_LOGIC_PATH} ${Tensile_OUTPUT_PATH} HIP)
if (WIN32 OR (VIRTUALENV_BIN_DIR AND VIRTUALENV_PYTHON_EXENAME))
set(CommandLine ${VIRTUALENV_BIN_DIR}/${VIRTUALENV_PYTHON_EXENAME} ${CommandLine})
Expand Down