Skip to content

Conversation

@TorreZuk
Copy link
Contributor

  • revise ISA detection as bootstrap only for benchmarking
  • fix kernel scheduling and generation to error if no ISA (but continue)
  • consider runtime error if no kernel ISA ?

@TorreZuk TorreZuk requested a review from a team as a code owner September 17, 2025 17:41
@TorreZuk TorreZuk added the gfxall PRs to develop built using all default gfx targets label Sep 17, 2025
Copilot AI review requested due to automatic review settings September 17, 2025 17:41
@TorreZuk TorreZuk requested review from Copilot and removed request for Copilot September 17, 2025 17:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR revises ISA (Instruction Set Architecture) detection to use kernel-specific ISA or print errors when unavailable, changing CurrentISA to be primarily for benchmarking bootstrap purposes.

  • Modifies kernel initialization to prefer kernel-specific ISA over global CurrentISA
  • Updates ISA detection logic to be more robust with fallback mechanisms
  • Improves error messaging and warning output for ISA-related issues

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
KernelWriterAssembly.py Updates kernel initialization to check for kernel ISA first, with error messaging for fallback
KernelWriter.py Adds ISA checking logic to kernel scheduling with error output for missing kernel ISA
Common.py Renames detection function, improves ISA detection flow, and updates warning messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TorreZuk
Copy link
Contributor Author

./library/src/build_tmp/TENSILE/assembly/asm-new.sh also has issues that must be resolved as it generated for the bootstrap ISA which would not be applicable. No change yet but can add to this PR

@TorreZuk
Copy link
Contributor Author

Latest work is to replace the CurrentISA global use for kernel generation so will close this PR. It highlighted the incorrect usage of the global but don't expect we are going this route.

@TorreZuk TorreZuk closed this Oct 21, 2025
@TorreZuk TorreZuk deleted the users/torrezuk/revise-isa-check branch October 21, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gfxall PRs to develop built using all default gfx targets organization: ROCm project: rocblas shared: tensile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants