Skip to content

docs(hipdnn): remove no_cpu_reference/no_gpu_reference once reference supports the bundle #15176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adickin-amd wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −1
Open

docs(hipdnn): remove no_cpu_reference/no_gpu_reference once reference supports the bundle #15176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dnn-providers/integration-tests/docs/adding-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,10 @@ one of these:

- **add golden data** produced by an independent implementation (see
[Golden data with DVC](#golden-data-with-dvc)), or
- **add the op to a reference executor**, or
- **add the op to a reference executor**. Then search the bundle metadata
(`*.meta.json`, `cases[].metadata`) for the matching `no_cpu_reference` or
`no_gpu_reference` flag, and try removing it for the ops and shapes the
executor now handles ([Disable a reference for a bundle](#disable-a-reference-for-a-bundle)), or
- **set `enforcement_level`** in the metadata to `applicability` (the engine
accepts the graph) or `buildable` (its plans compile), so that the bundle
claims only what the harness can check today, or
Expand All @@ -204,6 +207,13 @@ it. The harness never uses a disabled reference as an oracle
{ "format_version": 1, "generator": "…", "reference_source": "…", "no_cpu_reference": true }
```

- **Record why in `notes`.** Put the reason the reference is disabled (wrong
result, too slow, op or shape it does not support) in the `notes` metadata
field, so a later reader can tell whether it still applies.
- **Remove the flag once the reference supports the bundle.** A disabled
reference never runs the bundle, so nothing notices when it gains the op or
shape. When you add an op or shape to a reference executor, search the bundle
metadata for the flag and try removing it.
- **Disabling both requires golden data.** Add it first
([Golden data with DVC](#golden-data-with-dvc)). A bundle with both flags and
no declared golden data fails to load. `verify_golden_bundles.py` reports it
Expand Down
Loading