Repository navigation
docs(hipdnn): remove no_cpu_reference/no_gpu_reference once reference supports the bundle - #15176
Open
adickin-amd wants to merge 1 commit into
Open
adickin-amd wants to merge 1 commit into
adickin-amd wants to merge 1 commit into
Conversation
…MIOPEN-3138) Ask authors to record the reason for no_cpu_reference/no_gpu_reference in the metadata notes field and to remove the flag once the reference supports the bundle. Add a matching hint to the 'add the op to a reference executor' option.
github-actions
Bot
added
documentation
ci:docs-only
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents how to get out of a bundle-level reference disable.
no_cpu_reference/no_gpu_referencehave no way back: once a bundle sets one, that lane never runs the bundle, so nothing notices when the reference later gains the op or shape. This adds guidance toadding-tests.mdfor both the author who sets the flag and the author who adds reference support. Docs only.JIRA ID : ALMIOPEN-3138
Follow-up to a non-blocking review comment on #14346: #14346 (comment)
Risk Assessment
Risk 1. One markdown file, no code, build or test changes.
ASIC Coverage
Not applicable: documentation only.
Testing Summary
Docs only; no build or test run. The edited sections were re-read after the change to check list formatting and the in-page anchor. The
notesmetadata field the new text refers to is documented infile-formats.md(provenance-only string).Testing Checklist
Technical Changes
dnn-providers/integration-tests/docs/adding-tests.md:notesfield. Remove the flag once the reference supports the bundle.*.meta.json,cases[].metadata) for the matching flag and try removing it, and links to the section above.