Repository navigation
Conversation
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Collaborator
Author
|
Superseded — fix combined into the TheRock pin bump PR #14557. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows MSI build job requires
msi_version(the WiX-legal numeric ProductVersion).multi_arch_ci_windows.ymlexpects this asrocm_msi_package_versionfrom its caller, but this workflow was not forwarding it, leaving it empty and causing aValueErrorin the generator.Adds
rocm_msi_package_versionto thewindows_build_and_testcall, matching the pattern already used forrocm_package_version.Related: ROCm/TheRock#9547
🤖 Generated with Claude Code