Skip to content

ci: pass rocm_msi_package_version to windows_build_and_test - #14620

Closed
idass1990 wants to merge 2 commits into
developfrom
users/idass1990/pass_rocm_msi_package_version
Closed

idass1990 wants to merge 2 commits into
developfrom
users/idass1990/pass_rocm_msi_package_version

Conversation

@idass1990

Copy link
Copy Markdown
Collaborator

The Windows MSI build job requires msi_version (the WiX-legal numeric ProductVersion). multi_arch_ci_windows.yml expects this as rocm_msi_package_version from its caller, but this workflow was not forwarding it, leaving it empty and causing a ValueError in the generator.

Adds rocm_msi_package_version to the windows_build_and_test call, matching the pattern already used for rocm_package_version.

Related: ROCm/TheRock#9547

🤖 Generated with Claude Code

idass1990 and others added 2 commits October 28, 2026 17:40
Required for the Windows MSI build job to produce a valid installer.
ROCm/TheRock#9547

Co-Authored-By: Claude <noreply@anthropic.com>
Required for the Windows MSI build job to produce a valid installer.
ROCm/TheRock#9547

Co-Authored-By: Claude <noreply@anthropic.com>
@idass1990
idass1990 requested review from a team as code owners October 28, 2026 21:46
@github-actions github-actions Bot added github actions project: none Does not target any component labels Oct 28, 2026
@idass1990
idass1990 requested a review from ScottTodd October 28, 2026 21:51
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@idass1990

Copy link
Copy Markdown
Collaborator Author

Superseded — fix combined into the TheRock pin bump PR #14557.

@idass1990 idass1990 closed this Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant