Repository navigation
refactor(packaging): fetch Windows artifacts in a dedicated workflow step - #9547
Merged
Merged
Conversation
…step Move the artifact fetch out of generate_msi_wxs.py and into an explicit workflow step, mirroring the Linux native packages pattern. The build workflow now calls artifact_manager.py fetch directly with --run-id and --run-github-repo visible in the YAML, then passes the resulting directory to the generator via a new --artifact-dir flag (bypassing the internal fetch). This fixes a bug where artifact_github_repo was not propagated to the fetch when the workflow is called from another repository (e.g. rocm-libraries), causing the generator to look for the run's artifacts in the wrong S3 bucket. With an explicit fetch step, the bucket is resolved from the workflow env rather than from generator internals. Co-Authored-By: Claude <noreply@anthropic.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
4 tasks done
therock-pr-bot
Bot
removed
the
Not ready to Review
ScottTodd
approved these changes
Oct 27, 2026
1 task done
ScottTodd
added a commit
that referenced
this pull request
Oct 28, 2026
## Motivation CI is failing on ROCm/rocm-libraries#14471 and ROCm/rocm-systems#14369 when using the latest CI code from this repository on the release branch. These cherry-picks fix two issues: * #9547 to fix MSI build failures observed on ROCm/rocm-libraries#14471 * #9544 to fix DVC fetch failures #9537 ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md. --------- Co-authored-by: Ian Dass <145489691+idass1990@users.noreply.github.com> Co-authored-by: Geo Min <geomin12@amd.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
idass1990
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
idass1990
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Oct 28, 2026
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
idass1990
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
idass1990
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Oct 28, 2026
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
idass1990
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
idass1990
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Oct 28, 2026
Required for the Windows MSI build job to produce a valid installer. ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Oct 28, 2026
idass1990
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 28, 2026
ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
JonathanLichtnerAMD
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Oct 30, 2026
ROCm/TheRock#9547 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the artifact fetch out of
generate_msi_wxs.pyinto a dedicated workflow step, mirroring the Linux native packages pattern.Previously the fetch was embedded inside the generator, which meant
--run-github-repohad to be threaded through script arguments. When the workflow runs from another repo (e.g. rocm-libraries), the generator used the wrong S3 bucket becauseartifact_github_repowas not propagated. Part of #1987.Changes:
multi_arch_build_native_windows_packages.yml: adds a "Fetch Windows artifacts" step callingartifact_manager.py fetchdirectly, with--run-idand--run-github-repovisible in the YAML.multi_arch_ci_windows.yml: passesartifact_github_repo: github.repositoryso the fetch uses the correct bucket regardless of which repo triggers the workflow.generate_msi_wxs.py: adds--artifact-dirflag to accept a pre-fetched directory, skipping any internal fetch.🤖 Generated with Claude Code