Skip to content

fix(hipdnn): compare model artifact path canonically in descriptor loader test #14460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianHarrisonAMD merged 3 commits into from
Oct 28, 2026
Merged

fix(hipdnn): compare model artifact path canonically in descriptor loader test #14460

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
856f75a
fix(hipdnn): compare model artifact path canonically in descriptor lo…
BrianHarrisonAMD Oct 27, 2026
a11ca45
Merge branch 'develop' into users/bharriso/windows-temp-path-case
BrianHarrisonAMD Oct 28, 2026
ffc72fd
Merge branch 'develop' into users/bharriso/windows-temp-path-case
BrianHarrisonAMD Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions projects/hipdnn/plugin_sdk/tests/ingestor/TestDescriptorLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2552,9 +2552,10 @@ TEST(TestDescriptorLoader, AcceptsAModelArtifactInASubdirectoryOfTheDescriptor)

ASSERT_EQ(sets.size(), 1u);
ASSERT_TRUE(sets.front().heuristic.has_value());
EXPECT_EQ(
sets.front().heuristic->modelArtifactPath,
std::filesystem::absolute(dir.path() / "models" / "model.bin").lexically_normal().string());
// The parser resolves the artifact canonically, so the expectation is canonical too. On
// Windows that yields the on-disk case of each component, which %TEMP% need not match.
EXPECT_EQ(sets.front().heuristic->modelArtifactPath,
std::filesystem::weakly_canonical(dir.path() / "models" / "model.bin").string());
}

/// RFC 0019 §11.2: a `predict_engine` model gets the same artifact pre-flight as a ranker.
Expand Down
Loading