Repository navigation
fix(hipdnn): compare model artifact path canonically in descriptor loader test - #14460
Merged
Merged
Conversation
…ader test The UHD parser returns the weakly_canonical artifact path. On Windows that carries the on-disk case of each component (C:\Windows), while %TEMP% may spell it differently (C:\windows, C:\WINDOWS), so the absolute() expectation in AcceptsAModelArtifactInASubdirectoryOfTheDescriptor failed. Build the expectation with weakly_canonical, matching the parser and the sibling TestEnginePredictor check. Fixes #14451
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
BrianHarrisonAMD
marked this pull request as ready for review
October 27, 2026 14:12
BrianHarrisonAMD
enabled auto-merge (squash)
October 27, 2026 14:15
jdcampbe
approved these changes
Oct 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14460 +/- ##
===========================================
- Coverage 77.29% 76.08% -1.21%
===========================================
Files 2889 2886 -3
Lines 484830 481477 -3353
Branches 73230 72468 -762
===========================================
- Hits 374716 366288 -8428
- Misses 85381 90090 +4709
- Partials 24733 25099 +366
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestDescriptorLoader.AcceptsAModelArtifactInASubdirectoryOfTheDescriptorfails on the Windows nightly because it compares two spellings of the same path. The loader returns the canonical artifact path, which carries the on-disk case (C:\Windows); the test built its expectation from%TEMP%, which may spell itC:\windowsorC:\WINDOWS. The test now builds its expectation canonically, matching the loader. The loader itself does not change.Fixes #14451
Risk Assessment
Risk 1. Test-only change to one assertion; no product code changes.
ASIC Coverage
None. The test is host-only and arch-independent. The failure is Windows-specific, so the Windows nightly
hipdnnjob (gfx1151, gfx120X-all) is the confirming run.Testing Summary
TMPDIRset to a symlink makes the literal and canonical paths differ, the same mismatch as the Windows case difference. The old assertion fails this way; the new one passes.Testing Checklist
TMPDIR(Linux,-DHIPDNN_ENABLE_KERNEL_INGESTOR=ON) -TMPDIR=<symlink-to-/tmp> hipdnn_plugin_sdk_tests --gtest_filter='TestDescriptorLoader.*'- Status: Passed (173/173)hipdnntests - gfx1151, gfx120X-all - Status: PendingTechnical Changes
std::filesystem::weakly_canonical, as the sibling checkTestEnginePredictor.AModelPathMustNameAFileInsideTheDescriptorDirectoryalready does.