Repository navigation
refactor(hipsparse): retire 4.8 feature flags - #14144
Merged
amontoison merged 1 commit intoOct 23, 2026
Merged
Conversation
Remove the HIPSPARSE_ENABLE_SPGEAM option and the HIPSPARSE_WITH_SPGEAM config macro; the generic SpGEAM API is now always built (still gated on CUDA >= 13.3 for the NVIDIA backend).
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14144 +/- ##
========================================
Coverage 75.94% 75.94%
========================================
Files 2873 2873
Lines 477013 477013
Branches 71574 71574
========================================
Hits 362228 362228
Misses 90089 90089
Partials 24696 24696
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
kliegeois
approved these changes
Oct 22, 2026
ntrost57
approved these changes
Oct 23, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPGEAMbuild flag, which have been added in the 4.8.0 release.HIPSPARSE_ENABLE_SPGEAMCMake option, theHIPSPARSE_WITH_SPGEAMmacro inhipsparse-config.h.inand its DoxygenPREDEFINEDentry.hipsparse-config.h.inand theCheckFeatureFlagsguardrail are kept for future flags.Companion of #14137