Repository navigation
refactor(rocsparse): retire 5.1 feature flags - #14137
Merged
amontoison merged 1 commit intoOct 24, 2026
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
|
This will potentially have many conflicts in a week with the flood of PRs that will need to be merged. Just a thought. |
Contributor
Author
|
I propose that we merge this PR first in the upcoming cycle, as we did in the previous release. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14137 +/- ##
===========================================
+ Coverage 75.79% 75.84% +0.05%
===========================================
Files 2880 2881 +1
Lines 478823 479106 +283
Branches 71949 71999 +50
===========================================
+ Hits 362888 363343 +455
+ Misses 91072 90852 -220
- Partials 24863 24911 +48
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
kliegeois
approved these changes
Oct 22, 2026
ntrost57
approved these changes
Oct 23, 2026
Remove the SPMAT_SCALE, SDDMM_BATCHED, ELL_TRSV and DIAGONAL_SOLVE build options and config macros; the former ON code paths are now permanent. Move TRSM_REFACTORING to the 5.2 section of rocsparse-config.h.in.
amontoison
force-pushed
the
rocsparse_remove_old_feature_flags
branch
from
October 23, 2026 19:55
61b915a to
e30beba
Compare
amontoison
enabled auto-merge (rebase)
October 23, 2026 20:00
Contributor
TheRock Submodule Bump ActivityNewest first
|
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPMAT_SCALE,SDDMM_BATCHED,ELL_TRSVandDIAGONAL_SOLVE, which have been added in the 5.1.0 release.ROCSPARSE_ENABLE_SPMAT_SCALE,ROCSPARSE_ENABLE_SDDMM_BATCHED,BUILD_WITH_ELL_TRSV,BUILD_WITH_DIAGONAL_SOLVE), the#cmakedefineentries inrocsparse-config.h.inand the DoxygenPREDEFINEDentries. The former ON code paths are now permanent (library, tests, benchmarks, samples).ROCSPARSE_WITH_TRSM_REFACTORINGfrom the 5.1 to the 5.2 section ofrocsparse-config.h.in.Follows the same approach as #11265 (retirement of the 4.7 / 5.0 flags).