Repository navigation
feat(ci): Update TheRock reference to (c01e3a3 - 10-12-2026) and add skip-ci-config.toml - #13525
Merged
Merged
Conversation
Bumps all pinned TheRock workflow and source refs to `c01e3a3`, which adds path-based skip filtering for external repos (ROCm/TheRock#8800). That feature reads skip patterns from a TOML config sourced from the external repo, so this also adds `.github/skip-ci-config.toml` (seeded with the existing `SKIPPABLE_PATH_PATTERNS` from `.github/scripts/therock_configure_ci.py`) and passes the SHAs, event metadata, and config path through the `external_repo` payload so TheRock can compute the diff and decide whether CI is needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Points prebuilt stage artifact reuse at a current successful TheRock Multi-Arch CI run alongside the c01e3a3 ref bump. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
geomin12
changed the title
c01e3a3 - 10-12-2026) and add skip-ci-config.toml
github-actions
Bot
added
github actions
project: none
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
The c01e3a3 skip-filter change makes TheRock resolve the external repo diff from the `external_repo` payload. When the SHAs and event name are absent it falls back to `git diff HEAD^` against the new depth-1 sparse `external-repo-config` checkout, which has no parent commit and exits 128, failing setup. ASAN runs on pull requests, so it gets the full payload and can now also skip docs-only changes. The nightly workflows only run on schedule and workflow_dispatch, where `event_name` alone is enough for TheRock to recognize there is no meaningful diff and always run CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task done
dysu-amd
reviewed
Oct 13, 2026
TheRock c01e3a3 moved skip-CI handling out of configure_external_repo_ci.py, so the skip_tests output no longer exists and the gates referencing it were always-true dead conditions. Also align the skip-ci patterns with the rocm-systems companion bump so pre-commit config, CODEOWNERS, LICENSE, and labeler changes skip CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ScottTodd
pushed a commit
that referenced
this pull request
Oct 14, 2026
…d skip-ci-config.toml (#13525) Bumps all pinned TheRock workflow and source refs to `c01e3a3`, which adds path-based skip filtering for external repos (ROCm/TheRock#8800). That feature reads skip patterns from a TOML config sourced from the external repo, so this also adds `.github/skip-ci-config.toml` (seeded with the existing `SKIPPABLE_PATH_PATTERNS` from `.github/scripts/therock_configure_ci.py`) and passes the SHAs, event metadata, and config path through the `external_repo` payload so TheRock can compute the diff and decide whether CI is needed. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit fad26ec)
ScottTodd
pushed a commit
that referenced
this pull request
Oct 14, 2026
…d skip-ci-config.toml (#13525) Bumps all pinned TheRock workflow and source refs to `c01e3a3`, which adds path-based skip filtering for external repos (ROCm/TheRock#8800). That feature reads skip patterns from a TOML config sourced from the external repo, so this also adds `.github/skip-ci-config.toml` (seeded with the existing `SKIPPABLE_PATH_PATTERNS` from `.github/scripts/therock_configure_ci.py`) and passes the SHAs, event metadata, and config path through the `external_repo` payload so TheRock can compute the diff and decide whether CI is needed. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> (cherry picked from commit fad26ec)
Contributor
TheRock Submodule Bump ActivityNewest first
|
archana-ramalingam
added a commit
that referenced
this pull request
Oct 21, 2026
#13525 removed the skip_tests output from the configure job and moved path-based skipping into TheRock's setup, which already reports it through setup.outputs.enable_build_jobs. The rocjitsu artifacts gate still compared the missing output, which is always empty, so the clause was dead. Remove it; the gate keeps checking enable_build_jobs. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps all pinned TheRock workflow and source refs to
c01e3a3, which adds path-based skip filtering for external repos (ROCm/TheRock#8800).That feature reads skip patterns from a TOML config sourced from the external repo, so this also adds
.github/skip-ci-config.toml(seeded with the existingSKIPPABLE_PATH_PATTERNSfrom.github/scripts/therock_configure_ci.py) and passes the SHAs, event metadata, and config path through theexternal_repopayload so TheRock can compute the diff and decide whether CI is needed.