Repository navigation
Revert "feat(miopen): add validated gfx1101 Navi system DBs" - #13066
Merged
amd-chiranjeevi merged 1 commit intoOct 5, 2026
Merged
Conversation
This reverts commit 46f5d50.
⏳ Waiting on Required Checks⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
⏳ Waiting for required checks to start or finish:
|
amd-chiranjeevi
marked this pull request as ready for review
October 5, 2026 07:34
TriveniTadapaneni
self-requested a review
October 5, 2026 07:35
amd-chiranjeevi
deleted the
revert-12466-users/ysoliman/systemdb-navi-gfx1101
branch
October 5, 2026 07:39
Contributor
TheRock Submodule Bump ActivityNewest first
|
amd-chiranjeevi
added
bump-pr-revert
mattwill-amd
pushed a commit
that referenced
this pull request
Oct 14, 2026
JIRA ID: ALMIOPEN-2913 ## Motivation Only 5 of the 30 commits that landed against `projects/miopen` since the 3.6.2 version bump (`2d20a8f775e`, #12211) were reflected in `CHANGELOG.md`. The remaining 25 were reviewed and the 15 externally-visible ones documented, so the ROCm 10.2.0 section accurately reflects what shipped. 14 entries added (two of the fixes share one entry), plus a duplicate-heading fix. ### Added * [Conv] NHWC (channel-last) support in the GEMM convolution solvers, with new im2col/col2im kernels (#8693) * [Conv] Cross-architecture AI heuristics for immediate mode (`MIOPEN_FIND_MODE=2`), extending data-driven selection to Navi (#9680) * [Conv] Missing 3x3 stride-1 pad-1 tile-28 CK depthwise backward-data instance — ALMIOPEN-2423 (#11271) ### Changed * [Conv] `ConvHipConv` held out of the AI perf-config picker until its model is retrained — ALMIOPEN-2494 (#13337) * [Conv] CK byte-span gate lifted for forward and backward-data, now that CK fixes the 32-bit offset overflow itself — ALMIOPEN-2645 (#12396) ### Optimized * [Conv] `ConvDirectNaiveConv`: per-direction kernel files, float accumulators, spatial tiling, bfloat16 path — ALMIOPEN-2485/2486 (#7529) * Kernel cache reuses cached SQLite connections instead of reopening per load/store — ALMIOPEN-2598 (#11933) ### Resolved Issues * [Conv] Incorrect backward-weights results from the gfx950 direct kernel at `waves_q == 1` (missing cross-lane ordering on LDS staging reuse) — ROCM-31508 (#12406) * [Conv] Up to 8x slower hipconv `direct`/`direct_l1`/`direct_wgrad` under ROCm 10.1's full AMDGCN LTO default; fixed with `-fno-offload-lto` — ROCM-31334 (#12328) * [Conv] gfx942 multi-node training throughput regression from backward GEMM on small-batch 1x1 NHWC shapes — ROCM-31155 (#13232) * [Conv] Invalid CK perf-config entries in the gfx1201 and gfx1100 system databases — ROCM-29026 (#12088, #12117) * [BatchNorm] JIT compilation failures on non-GFX9 targets; Welford DPP assembly restricted to GFX9 — ALMIOPEN-2838 (#12889) * Out-of-bounds write in `miopenLoadSolution` when a serialized solution carries more than three work dimensions — ROCM-31082 (#12242) * `uint64_t` typedef conflict between `miopen_cstdint.hpp` and system `<stdint.h>` on LP64 Linux (#12623) ## Technical Details Single-file change to `projects/miopen/CHANGELOG.md`. The 10.2.0 section had **two** `### Resolved Issues` headings. The two entries under the trailing one (`ConvHipConv` gfx1250 crash/LDS race, and the perf-db reload config loss) were merged into the first, and the trailing heading removed — this accounts for the 2 removed bullets in the diff. Section order is now `Resolved Issues → Added → Changed → Optimized → Removed`, matching the 3.6.1 section. `Optimized` is new to this release section. Already documented, so untouched: #12874 (reduce int32 rejection), #12000 / #13016 / #13213 (hipconv v0.3.1 / v0.3.2 / v0.4.0), #11761 (gfx803 removal). ## Notes Deliberately excluded as not externally visible (10 commits): * **hipDNN convolution forwarding (#12276)** — `MIOPEN_ENABLE_HIPDNN_WRAPPER` defaults to `OFF` (`projects/miopen/CMakeLists.txt:162`), so no shipped build compiles the forwarding code and the runtime `MIOPEN_HIPDNN_FORWARDING` flag has nothing to enable. * **Test-only**: #13289 (gfx1250 depthwise test applicability, ALMIOPEN-2841), #11610 (hipDNN parity harness), #12660 (Jenkins status post). * **Internal kernel-math cleanup, generated ISA unchanged**: #13312 (drop direct `__ocml` calls), #13190 (remove broken single-argument `__half` overloads). * **Add/revert pairs, net no change**: #12466 + #13066 (gfx1101 Navi system DBs), #12496 + #12800 (gfx1250 in the dev image arch lists). ## Risk Assessment Documentation-only change to a single Markdown file; no code, build, or runtime impact. **Risk Level: 🟢 Low** ## Test Plan None required — Markdown-only. Verified that the entry topics are not already documented elsewhere in the file, that no content was lost when merging the duplicate heading, and that every new entry maps to a commit in `2d20a8f775e..origin/develop -- projects/miopen`. ## Test Result 16 bullets added, 2 relocated — 14 net-new entries covering 15 commits. Duplicate heading removed; section ordering matches 3.6.1. Co-authored-by: Claude <noreply@anthropic.com>
yassinsolim
added a commit
that referenced
this pull request
Oct 14, 2026
Reapply "feat(miopen): add validated gfx1101 Navi system DBs", which was reverted in aa41b4f (#13066) because the multi-family Windows build did not ship the gfx1101 databases. The preceding commit fixes that packaging bug by moving the Windows system databases to share/miopen/db, so the files now land in miopen_lib_gfx1101. Restored: the gfx110136 find-db and perf-db pair, gfx1101 in ALL_GPU_DATABASES, the compute-unit-suffixed runtime basename in Handle::GetDbBasename, and the gfx1101 StaticFDBSync parameter. The database contents are byte-identical to the pair validated in #12466. The revert also dropped four gfx110220 CK perf-config rows. Those rows are left in place here. They resolve under the current large-tensor gate and pass StaticFDBSync, so there is no reason to remove them. Issue: #13069 JIRA ID: ALMIOPEN-1195
yassinsolim
added a commit
that referenced
this pull request
Oct 16, 2026
Reapply "feat(miopen): add validated gfx1101 Navi system DBs", which was reverted in aa41b4f (#13066) because the multi-family Windows build did not ship the gfx1101 databases. The preceding commit fixes that packaging bug by moving the Windows system databases to share/miopen/db, so the files now land in miopen_lib_gfx1101. Restored: the gfx110136 find-db and perf-db pair, gfx1101 in ALL_GPU_DATABASES, the compute-unit-suffixed runtime basename in Handle::GetDbBasename, and the gfx1101 StaticFDBSync parameter. The database contents are byte-identical to the pair validated in #12466. The revert also dropped four gfx110220 CK perf-config rows. Those rows are left in place here. They resolve under the current large-tensor gate and pass StaticFDBSync, so there is no reason to remove them. Issue: #13069 JIRA ID: ALMIOPEN-1195
yassinsolim
added a commit
that referenced
this pull request
Oct 17, 2026
Reapply "feat(miopen): add validated gfx1101 Navi system DBs", which was reverted in aa41b4f (#13066) because the multi-family Windows build did not ship the gfx1101 databases. The preceding commit fixes that packaging bug by moving the Windows system databases to share/miopen/db, so the files now land in miopen_lib_gfx1101. Restored: the gfx110136 find-db and perf-db pair, gfx1101 in ALL_GPU_DATABASES, the compute-unit-suffixed runtime basename in Handle::GetDbBasename, and the gfx1101 StaticFDBSync parameter. The database contents are byte-identical to the pair validated in #12466. The revert also dropped four gfx110220 CK perf-config rows. Those rows are left in place here. They resolve under the current large-tensor gate and pass StaticFDBSync, so there is no reason to remove them. Issue: #13069 JIRA ID: ALMIOPEN-1195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR: #12466
Fixes Issue: #13069
Test run: https://github.com/ROCm/TheRock/actions/runs/37267418725/job/111652028584 <-- Passed