[JonathanLichtnerAMD]

JIRA ID: ROCM-31082

Motivation

miopenLoadSolution deserializes kernel work-dimension vectors
(local_work_dims / global_work_dims) from a serialized Solution blob and
copies them into a fixed std::array<size_t, 3> inside the HIPOCKernel
constructor. The only bounds check on that copy was a debug-only assert,
which is compiled out in release builds. A blob with more than 3 entries in
either array is attacker/corruption-controlled input that overruns the
destination array — an out-of-bounds write. This PR closes that gap.

Technical Details

• miopen/src/solution.cpp: added ValidateSerializedWorkDims(), called from
  SerializedSolutionKernelInfo::from_json right after the work-dims vectors
  are parsed, before any kernel object is constructed. Throws
  miopenStatusInvalidValue if the vector is empty or has more than 3
  entries.
• miopen/src/include/miopen/hipoc_kernel.hpp: replaced the release-mode-inert
  assert(!local_dims.empty() && local_dims.size() <= 3) (and the global_dims
  equivalent) in the HIPOCKernel constructor with MIOPEN_THROW(miopenStatusInternalError, ...)
  checks against the actual array capacity (ldims.size() / gdims.size()),
  so the same invariant is enforced in release builds as a second line of
  defense for any other caller path into this constructor. By this point the
  work dims should already be validated at the deserialization boundary above,
  so a violation here is an internal invariant break rather than a bad
  caller-supplied parameter.
• miopen/src/include/miopen/solution.hpp: declared and documented the new
  ValidateSerializedWorkDims helper (MIOPEN_INTERNALS_EXPORT) so it's
  reusable and independently testable.
• Added miopen/test/gtest/solution_load_work_dims.cpp, a CPU-only regression
  test exercising the helper directly with an oversized vector, an empty
  vector, and valid 1-3 element vectors — no GPU or full solution round-trip
  needed.
• miopen/src/comgr.cpp: added a direct #include <cassert>. This file uses
  assert() but was only getting <cassert> transitively via
  miopen/kernel.hpp -> hipoc_kernel.hpp; removing that transitive include
  above broke its build (caught by CI), so it now includes <cassert>
  directly instead of relying on an implicit dependency.

Risk Assessment

The change only adds input validation (bounds checks that throw on invalid
input) on a narrow deserialization path and a kernel constructor, plus an
unrelated one-line include fix; it does not alter behavior for any valid
work-dimensions input, so blast radius is small.

Risk Level: 🟢 Low

Impacted Components

• miopen/src/solution.cpp (SerializedSolutionKernelInfo::from_json)
• miopen/src/include/miopen/solution.hpp
• miopen/src/include/miopen/hipoc_kernel.hpp (HIPOCKernel constructor)
• miopen/src/comgr.cpp (missing direct <cassert> include)
• New test: miopen/test/gtest/solution_load_work_dims.cpp

Potential Side Effects

None expected for well-formed solutions (1-3 work dimensions, the only valid
case today). Any caller that was previously relying on the debug-only assert
being absent in release builds to pass out-of-range dimensions would now get
a thrown exception instead of undefined behavior — this is the intended
fix, not a regression.

Mitigation Steps

Added a dedicated regression test covering the empty, oversized, and valid
input cases. No feature flag or staged rollout needed given the contained,
input-validation-only nature of the change.

Test Plan

Added solution_load_work_dims.cpp, a new CPU-only GTest target that calls
miopen::ValidateSerializedWorkDims directly with an oversized vector (4
entries), an empty vector, and valid 1/2/3-entry vectors, asserting throw vs.
no-throw and checking the thrown status code.

Test Result

CI ran on this PR and caught the comgr.cpp transitive-include break
described above; that has been fixed in a follow-up commit. CI is expected to
build and execute solution_load_work_dims.cpp as part of the standard gtest
suite on the next run.

[therock-pr-bot]

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🎉 All checks passed! This PR is ready for review.

[averinevg]

LGTM

[assistant-librarian]

TheRock Submodule Bump Activity

Newest first

• 2026-09-22 — Included in TheRock via ROCm/TheRock#8406.