Repository navigation
fix(ci): install tensilelite requirements for rocjitsu sidecar - #12425
Merged
newling merged 1 commit intoSep 27, 2026
Merged
Conversation
github-actions
Bot
added
github actions
project: none
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
force-pushed
the
users/newling/rocjitsu-sidecar-requirements
branch
from
September 22, 2026 22:53
319209d to
ee28920
Compare
Alex-Vasile
approved these changes
Sep 23, 2026
talumbau
self-requested a review
September 23, 2026 19:55
talumbau
approved these changes
Sep 23, 2026
newling
force-pushed
the
users/newling/rocjitsu-sidecar-requirements
branch
from
September 23, 2026 19:58
ee28920 to
e1f6410
Compare
newling
enabled auto-merge (squash)
September 23, 2026 19:58
newling
force-pushed
the
users/newling/rocjitsu-sidecar-requirements
branch
3 times, most recently
from
September 25, 2026 23:59
7d3fd19 to
a177a17
Compare
newling
force-pushed
the
users/newling/rocjitsu-sidecar-requirements
branch
from
September 27, 2026 18:33
a177a17 to
84f5d98
Compare
1 task
newling
added a commit
that referenced
this pull request
Sep 28, 2026
## Summary The rocjitsu sidecar relied on therock's common test environment to provide tensilelite's Python dependencies. After those dependencies were split out by project, `joblib` was no longer installed and the tensilelite workload failed during import before running under rocjitsu. Install the tensilelite test requirements explicitly after unpacking the test artifacts, using the requirements file shipped with the artifact by #11396. ## Testing - Pre-commit and `actionlint` - Validated the artifact requirements path against the installed artifact layout JIRA ID: AIHPBLAS-3605 (cherry picked from commit 973351c)
Contributor
TheRock Submodule Bump ActivityNewest first
|
newling
added a commit
that referenced
this pull request
Oct 29, 2026
Repository members and owners can comment `/docs-preview` on a pull request to request a temporary documentation preview on Read the Docs. This feature and its cleanup workflow were introduced in [#1413](#1413). When the PR closes, the cleanup workflow looks for the bot's preview comment and deactivates the corresponding Read the Docs version. Preview creation explicitly supports only branches in `ROCm/rocm-libraries` and rejects PRs whose source branch is in a fork. Cleanup, however, runs for every closed PR. On a fork PR, GitHub withholds repository secrets from the `pull_request` workflow, so cleanup fails while generating its GitHub App token, before it can check whether a preview exists. For example, [the cleanup job after #12425 merged failed at token creation](https://github.com/ROCm/rocm-libraries/actions/runs/36353595348/job/108716843959), even though that PR had no documentation preview. Run the cleanup job only when the PR's source repository matches the repository running the workflow. Fork PRs then skip cleanup before accessing secrets, while previews from branches in this repository retain their existing cleanup behavior. This change aligns cleanup with the preview system's current limitations. Supporting documentation previews from forks would be a separate feature: preview creation would need to accept fork sources, and trusted automation would need to create and deactivate those previews while keeping credentials isolated from contributor-controlled code. Validation: the root pre-commit checks and `git diff --check` pass after rebasing onto `origin/develop`. `actionlint` reports only the existing warning about inline use of `github.head_ref`, with identical diagnostics on the base and this branch. The close-event behavior has not yet been exercised by a new GitHub Actions run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rocjitsu sidecar relied on therock's common test environment to provide tensilelite's Python dependencies. After those dependencies were split out by project,
joblibwas no longer installed and the tensilelite workload failed during import before running under rocjitsu.Install the tensilelite test requirements explicitly after unpacking the test artifacts, using the requirements file shipped with the artifact by #11396.
Testing
actionlintJIRA ID: AIHPBLAS-3605