Repository navigation
fix(ci): skip docs preview cleanup for fork PRs - #12648
Merged
newling merged 1 commit intoOct 29, 2026
Merged
Conversation
github-actions
Bot
added
github actions
project: none
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
marked this pull request as ready for review
September 29, 2026 15:24
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
from
September 29, 2026 15:24
efdad03 to
e23169c
Compare
jinchen62
approved these changes
Sep 30, 2026
geomin12
approved these changes
Oct 13, 2026
newling
enabled auto-merge (squash)
October 14, 2026 17:09
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
6 times, most recently
from
October 19, 2026 14:39
bd783a3 to
8b5e57b
Compare
1 task done
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
from
October 19, 2026 21:22
8b5e57b to
4fdd463
Compare
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
2 times, most recently
from
October 22, 2026 19:27
f4d8c8e to
f2b5362
Compare
neon60
approved these changes
Oct 23, 2026
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
from
October 23, 2026 16:27
f2b5362 to
58faea3
Compare
alexxu-amd
approved these changes
Oct 23, 2026
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
from
October 24, 2026 00:24
58faea3 to
2efd090
Compare
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
4 times, most recently
from
October 27, 2026 01:24
d43a7a7 to
b00c398
Compare
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
2 times, most recently
from
October 28, 2026 17:00
ae28fd8 to
85bf92e
Compare
newling
disabled auto-merge
October 28, 2026 19:25
newling
enabled auto-merge (squash)
October 29, 2026 17:27
newling
force-pushed
the
users/newling/docs-preview-cleanup-skip-forks
branch
from
October 29, 2026 17:27
85bf92e to
51a10ef
Compare
newling
added a commit
to ROCm/TheRock
that referenced
this pull request
Oct 29, 2026
Windows component tests stop before artifact download when Chocolatey fails to install Ninja ([HTTP 499 failure](https://github.com/ROCm/rocm-libraries/actions/runs/39270899358/job/118164640583)). Remove that shared setup step and install Ninja through the existing test virtual environment only for jobs that need it. Linux uses the same requirement, and both base test Dockerfiles drop their system Ninja package. Ninja 1.13.2 is currently the latest release on [PyPI](https://pypi.org/project/ninja/) and [upstream](https://github.com/ninja-build/ninja/releases/tag/v1.13.2). Use `ninja>=1.13.2` rather than an exact pin: this excludes the known MSVC linker response-file regression while allowing newer releases, matching the minimum used in #8929. The Python wheel contains the native executable and uses the test virtual environment's existing PATH setup. In the Windows [libhipcxx](https://github.com/ROCm/TheRock/actions/runs/39320816466/job/118353150368#step:12:1) and [hipDNN installation-test](https://github.com/ROCm/TheRock/actions/runs/39320816466/job/118353149786#step:12:1) logs, uv resolves, prepares and installs Ninja in about 0.4–1.6 seconds. A successful [Chocolatey install through internal Nexus](https://github.com/ROCm/TheRock/actions/runs/39320816466/job/118302133725) takes about 4.7 seconds including command startup. These are different runners and cache states, so this is an observed cost comparison, not a controlled pip-versus-Chocolatey benchmark. The other direct CI Chocolatey installs select internal Nexus; the removed test-setup call contacted the public feed. Installing through the test venv removes that separate package-manager dependency. Requirements remain registered per consuming job in TheRock until the components ship their own requirements files in test artifacts. Local GitHub Actions unit tests, pre-commit, Windows wheel checks, and a Linux CMake build/CTest using the venv's Ninja pass. The previous revision passed the Windows Ninja-consuming component jobs; CI for this revision and validation of rebuilt test images remain pending. ISSUE ID : ROCm/rocm-libraries#12648 - [x] Reviewed the [contributing guidelines](https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md).
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository members and owners can comment
/docs-previewon a pull request to request a temporary documentation preview on Read the Docs. This feature and its cleanup workflow were introduced in #1413. When the PR closes, the cleanup workflow looks for the bot's preview comment and deactivates the corresponding Read the Docs version.Preview creation explicitly supports only branches in
ROCm/rocm-librariesand rejects PRs whose source branch is in a fork. Cleanup, however, runs for every closed PR. On a fork PR, GitHub withholds repository secrets from thepull_requestworkflow, so cleanup fails while generating its GitHub App token, before it can check whether a preview exists. For example, the cleanup job after #12425 merged failed at token creation, even though that PR had no documentation preview.Run the cleanup job only when the PR's source repository matches the repository running the workflow. Fork PRs then skip cleanup before accessing secrets, while previews from branches in this repository retain their existing cleanup behavior.
This change aligns cleanup with the preview system's current limitations. Supporting documentation previews from forks would be a separate feature: preview creation would need to accept fork sources, and trusted automation would need to create and deactivate those previews while keeping credentials isolated from contributor-controlled code.
Validation: the root pre-commit checks and
git diff --checkpass after rebasing ontoorigin/develop.actionlintreports only the existing warning about inline use ofgithub.head_ref, with identical diagnostics on the base and this branch. The close-event behavior has not yet been exercised by a new GitHub Actions run.