Skip to content

fix(rocthrust): Set BUILD_TEST and BUILD_BENCHMARK to prev value not ON #12391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NguyenNhuDi merged 2 commits into from
Sep 22, 2026
Merged

fix(rocthrust): Set BUILD_TEST and BUILD_BENCHMARK to prev value not ON #12391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b01c35
fixed buggie
NguyenNhuDi Sep 21, 2026
8994625
unset temp vars
NguyenNhuDi Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions projects/rocthrust/cmake/Dependencies.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,8 @@ if(USER_BUILD_BENCHMARK)

# FetchContent runs in-process, so rocthrust's BUILD_BENCHMARK=ON and BUILD_TEST=ON leaks into
# rocrand and causes its benchmarks and unit tests to build. Suppress that here.
set(_ROCTHRUST_SAVED_BUILD_BENCHMARK "${BUILD_BENCHMARK}")
set(_ROCTHRUST_SAVED_BUILD_TEST "${BUILD_TEST}")
set(BUILD_BENCHMARK OFF)
set(BUILD_TEST OFF)

Expand All @@ -474,8 +476,12 @@ if(USER_BUILD_BENCHMARK)
LOG_INSTALL TRUE
)
FetchContent_MakeAvailable(rocrand)
set(BUILD_BENCHMARK ON)
set(BUILD_TEST ON)
set(BUILD_BENCHMARK "${_ROCTHRUST_SAVED_BUILD_BENCHMARK}")
set(BUILD_TEST "${_ROCTHRUST_SAVED_BUILD_TEST}")
Comment thread
NguyenNhuDi marked this conversation as resolved.
Resolved

unset(_ROCTHRUST_SAVED_BUILD_BENCHMARK)
unset(_ROCTHRUST_SAVED_BUILD_TEST)

if(NOT TARGET roc::rocrand)
add_library(roc::rocrand ALIAS rocrand)
endif()
Expand Down
Loading