Repository navigation
fix(rocthrust): Set BUILD_TEST and BUILD_BENCHMARK to prev value not ON - #12391
Merged
Merged
Conversation
|
✅ Author chose to skip pr bot run hence removing label ( |
NguyenNhuDi
changed the title
BUILD_TEST and BUILD_BENCHMARK to prev value not ONBUILD_TEST and BUILD_BENCHMARK to prev value not ON
amd-jmahovsky
approved these changes
Sep 21, 2026
amd-jmahovsky
left a comment
amd-jmahovsky
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but one possible cleanup
NguyenNhuDi
enabled auto-merge (squash)
September 21, 2026 20:04
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12391 +/- ##
===========================================
- Coverage 69.67% 69.67% -0.00%
===========================================
Files 2932 2932
Lines 481712 481662 -50
Branches 69448 69448
===========================================
- Hits 335630 335580 -50
Misses 121892 121892
Partials 24190 24190
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
1 task done
stanleytsang-amd
pushed a commit
that referenced
this pull request
Oct 2, 2026
…not `ON` (#12391) ## Motivation While building for `CUDA` backend with `hip-nv-dev` preset, `BUILD_TEST` was getting set to `ON` even though preset sets it to `OFF`. This causes build errors when building benchmarks for `rocthrust`. ## Technical Details There was an issue where `BUILD_TEST` and `BUILD_BENCHMARK` was leaking into `rocRAND` build. There was a fix in prs #11045 and #10956, however these PRs just set set `BUILD_TEST` and `BUILD_BENCHMARK` to `ON`. In cases where only `BUILD_TEST` was set to `ON` or only `BUILD_BENCHMARK` was set to `ON` this would turn on the other no matter what. In the case of `hip-nv-dev` preset this would set `BUILD_TEST` to `ON` even though in this case we need it to be set `OFF`. By storing the variables into temp variables before forcing them `OFF` we can restore the original state after `rocRAND` is finished. @skip-pr-bot ## Test Plan Local compilation with `hip-nv-dev` preset. ## Test Result No more cmake errors. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.
Naraenda
pushed a commit
that referenced
this pull request
Oct 5, 2026
…not `ON` (#12391) ## Motivation While building for `CUDA` backend with `hip-nv-dev` preset, `BUILD_TEST` was getting set to `ON` even though preset sets it to `OFF`. This causes build errors when building benchmarks for `rocthrust`. ## Technical Details There was an issue where `BUILD_TEST` and `BUILD_BENCHMARK` was leaking into `rocRAND` build. There was a fix in prs #11045 and #10956, however these PRs just set set `BUILD_TEST` and `BUILD_BENCHMARK` to `ON`. In cases where only `BUILD_TEST` was set to `ON` or only `BUILD_BENCHMARK` was set to `ON` this would turn on the other no matter what. In the case of `hip-nv-dev` preset this would set `BUILD_TEST` to `ON` even though in this case we need it to be set `OFF`. By storing the variables into temp variables before forcing them `OFF` we can restore the original state after `rocRAND` is finished. @skip-pr-bot ## Test Plan Local compilation with `hip-nv-dev` preset. ## Test Result No more cmake errors. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.
Naraenda
pushed a commit
that referenced
this pull request
Oct 7, 2026
…not `ON` (#12391) ## Motivation While building for `CUDA` backend with `hip-nv-dev` preset, `BUILD_TEST` was getting set to `ON` even though preset sets it to `OFF`. This causes build errors when building benchmarks for `rocthrust`. ## Technical Details There was an issue where `BUILD_TEST` and `BUILD_BENCHMARK` was leaking into `rocRAND` build. There was a fix in prs #11045 and #10956, however these PRs just set set `BUILD_TEST` and `BUILD_BENCHMARK` to `ON`. In cases where only `BUILD_TEST` was set to `ON` or only `BUILD_BENCHMARK` was set to `ON` this would turn on the other no matter what. In the case of `hip-nv-dev` preset this would set `BUILD_TEST` to `ON` even though in this case we need it to be set `OFF`. By storing the variables into temp variables before forcing them `OFF` we can restore the original state after `rocRAND` is finished. @skip-pr-bot ## Test Plan Local compilation with `hip-nv-dev` preset. ## Test Result No more cmake errors. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While building for
CUDAbackend withhip-nv-devpreset,BUILD_TESTwas getting set toONeven though preset sets it toOFF. This causes build errors when building benchmarks forrocthrust.Technical Details
There was an issue where
BUILD_TESTandBUILD_BENCHMARKwas leaking intorocRANDbuild. There was a fix in prs #11045 and #10956, however these PRs just set setBUILD_TESTandBUILD_BENCHMARKtoON. In cases where onlyBUILD_TESTwas set toONor onlyBUILD_BENCHMARKwas set toONthis would turn on the other no matter what. In the case ofhip-nv-devpreset this would setBUILD_TESTtoONeven though in this case we need it to be setOFF.By storing the variables into temp variables before forcing them
OFFwe can restore the original state afterrocRANDis finished.@skip-pr-bot
Test Plan
Local compilation with
hip-nv-devpreset.Test Result
No more cmake errors.
Submission Checklist