Skip to content

docs(rocprim): remove outdated spirv docs and remove unused and unnecessary define check #11614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NguyenNhuDi merged 3 commits into from
Sep 2, 2026
Merged

docs(rocprim): remove outdated spirv docs and remove unused and unnecessary define check #11614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2acbdd7
docs(rocprim): remove outdated spirv docs
NB4444 Sep 2, 2026
e8ca900
fix(rocprim): remove unused and unnecessary define check
NB4444 Sep 2, 2026
d05633b
Merge branch 'develop' into users/NB4444/remove-old-spirv-docs
NguyenNhuDi Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions projects/rocprim/docs/how-to/rocPRIM-spir-v.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,19 @@ Using SPIR-V with rocPRIM

rocPRIM supports building with target-agnostic SPIR-V.

.. note::

SPIR-V is in an early access state. Using it in production is not recommended.

To build with SPIR-V, set the ``ROCPRIM_EXPERIMENTAL_SPIRV`` parameter to any non-zero value, and set ``--offload-arch`` to ``amdgcnspirv``.
To build with SPIR-V, set ``--offload-arch`` to ``amdgcnspirv``.

For example, with hipcc:

.. code:: shell

hipcc -DROCPRIM_EXPERIMENTAL_SPIRV=1 --offload-arch=amdgcnspirv
hipcc --offload-arch=amdgcnspirv

For example, with cmake:

.. code:: shell

cmake -DCMAKE_CXX_FLAGS="-DROCPRIM_EXPERIMENTAL_SPIRV=1 --offload-arch=amdgcnspirv"


.. note::

rocPRIM does not support mixed compilation targets. No other target can be set when ``--offload-arch=amdgcnspirv`` is used.

Setting ``ROCPRIM_EXPERIMENTAL_SPIRV`` will disable all config dispatching.

cmake --offload-arch=amdgcnspirv"

When targeting SPIR-V, the hardware wavefront size (also known as warp size) is not known
at compile time.
Expand Down
2 changes: 1 addition & 1 deletion projects/rocprim/rocprim/include/rocprim/device/config_types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ constexpr arch::wavefront::target get_wavefront_size(const gen gen = gen::unknow
*/
constexpr target_arch device_target_arch()
{
#if defined(__amdgcn_processor__) && !defined(ROCPRIM_EXPERIMENTAL_SPIRV)
#if defined(__amdgcn_processor__)
// The terminating zero is not counted in the length of the string
return get_target_arch_from_name(__amdgcn_processor__,
sizeof(__amdgcn_processor__) - sizeof('\0'));
Expand Down
4 changes: 0 additions & 4 deletions projects/rocprim/test/rocprim/test_config_dispatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ TEST(RocprimConfigDispatchTests, GetTargetArch)
ASSERT_TRUE(get_target_arch_from_name("gfx803", 6) == target_arch::gfx803);
}

#if !defined(ROCPRIM_EXPERIMENTAL_SPIRV) // This macro disables the config_dispatching

TEST(RocprimConfigDispatchTests, HostMatchesDevice)
{
const int device_id = test_common_utils::obtain_device_from_ctest();
Expand Down Expand Up @@ -147,8 +145,6 @@ TEST(RocprimConfigDispatchTests, ParseCommonArches)
ASSERT_EQ(parse_gcn_arch("gfx90a:sramecc+:xnack-"), target_arch::gfx90a);
}

#endif // ROCPRIM_EXPERIMENTAL_SPIRV

#ifndef _WIN32
TEST(RocprimConfigDispatchTests, DeviceIdFromStream)
{
Expand Down
Loading