Repository navigation
docs(rocprim): remove outdated spirv docs and remove unused and unnecessary define check - #11614
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
NguyenNhuDi
approved these changes
Sep 2, 2026
spolifroni-amd
approved these changes
Sep 2, 2026
NguyenNhuDi
enabled auto-merge (squash)
September 2, 2026 18:43
assistant-librarian Bot
pushed a commit
to ROCm/rocPRIM
that referenced
this pull request
Sep 2, 2026
docs(rocprim): remove outdated spirv docs and remove unused and unnecessary define check (#11614) ## Motivation Removal of outdated spirv documentation. JIRA ID : EXSWSTRHPC-301 ## Technical Details There is no longer a problem with having other arches next to spirv. Before we had different host code for the config system with and without spriv. We changed how it works now so this should no longer be a problem, it works now the same on the host for spirv and non-spirv. The define was only used in the tests (still work without it) and in a helper function. The helper function is only used in a kernel where it is guarded by other spirv checks. ## Test Plan Run all tests with spirv. ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Contributor
TheRock Submodule Bump ActivityNewest first
|
stanleytsang-amd
pushed a commit
that referenced
this pull request
Sep 18, 2026
…essary define check (#11614) ## Motivation Removal of outdated spirv documentation. JIRA ID : EXSWSTRHPC-301 ## Technical Details There is no longer a problem with having other arches next to spirv. Before we had different host code for the config system with and without spriv. We changed how it works now so this should no longer be a problem, it works now the same on the host for spirv and non-spirv. The define was only used in the tests (still work without it) and in a helper function. The helper function is only used in a kernel where it is guarded by other spirv checks. ## Test Plan Run all tests with spirv. ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>
illsilin
pushed a commit
to igorluppi/rocm-libraries
that referenced
this pull request
Oct 1, 2026
…essary define check (ROCm#11614) ## Motivation Removal of outdated spirv documentation. JIRA ID : EXSWSTRHPC-301 ## Technical Details There is no longer a problem with having other arches next to spirv. Before we had different host code for the config system with and without spriv. We changed how it works now so this should no longer be a problem, it works now the same on the host for spirv and non-spirv. The define was only used in the tests (still work without it) and in a helper function. The helper function is only used in a kernel where it is guarded by other spirv checks. ## Test Plan Run all tests with spirv. ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Removal of outdated spirv documentation.
JIRA ID : EXSWSTRHPC-301
Technical Details
There is no longer a problem with having other arches next to spirv. Before we had different host code for the config system with and without spriv. We changed how it works now so this should no longer be a problem, it works now the same on the host for spirv and non-spirv.
The define was only used in the tests (still work without it) and in a helper function. The helper function is only used in a kernel where it is guarded by other spirv checks.
Test Plan
Run all tests with spirv.
Test Result
Submission Checklist