[stride when Swizzle] Accept stride_a=0, support --any_stride for bench#1079
Merged
Conversation
mengzcai
force-pushed
the
user/mengzcai/strideForSwizzleA
branch
from
7e06e78 to
d236465
Compare
KKyang
previously approved these changes
Aug 6, 2025
solaslin
force-pushed
the
user/mengzcai/strideForSwizzleA
branch
from
d236465 to
b60d99e
Compare
solaslin
previously requested changes
Aug 7, 2025
Contributor
There was a problem hiding this comment.
I'd like to add stride_a: 0 back to gtest yaml, but I know we can't write stride_a: [0, default].
One option is to copy-paste the swizzle gtest and make another ......_swizzleA_stride_a0.
But there is actually a simpler way to achieve this:
Add a definition in the matmul_gtest.yaml:
- &swizzleA_arguments
- {}
- { stride_a: 0 }
Then use arguments: in your test case:
- name: matmul_swizzleA
category: pre_checkin
function:
matmul: *real_precisions_swizzleA_support
arguments: *swizzleA_arguments
M: [128, 129]
N: [128, 129]
K: [128, 129]
This will expand the tests like stride_a: [0, unset]
I strongly recommend to add this since this PR is proving swizzle accepts stride_a 0.
Remember to add both on matmul_swizzleA and matmul_extapi_swizzleA
solaslin
requested changes
Aug 7, 2025
mengzcai
force-pushed
the
user/mengzcai/strideForSwizzleA
branch
2 times, most recently
from
28e883b to
a0b9426
Compare
Contributor
Author
|
@solaslin Thanks for the provided method. It has been added to GTest. |
solaslin
reviewed
Aug 8, 2025
mengzcai
force-pushed
the
user/mengzcai/strideForSwizzleA
branch
from
a0b9426 to
bbae294
Compare
solaslin
approved these changes
Aug 8, 2025
Contributor
solaslin
left a comment
solaslin
left a comment
There was a problem hiding this comment.
Thanks for changing ! LG
add swizzle_arguments to gtest: defualt stride & stride0 remove setDefaultSwizzledBatchedStride()
mengzcai
force-pushed
the
user/mengzcai/strideForSwizzleA
branch
from
89131db to
f0c9d69
Compare
jichangjichang
approved these changes
Aug 8, 2025
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Aug 12, 2025
[stride when Swizzle] Accept stride_a=0, support --any_stride for bench (#1079) previous PR: [#979](ROCm/rocm-libraries#979) Co-authored-by: mengzcai <mengzcai@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previous PR: #979