fix(rocrand): resolve issues with nvcc compilation #1047
Merged
stanleytsang-amd merged 4 commits intoAug 18, 2025
Merged
Conversation
Member
Naraenda
commented
Aug 4, 2025
Naraenda
commented
- Resolves compilation issues when building with nvcc.
- Resolve a bunch of instances where a device function was used that was defined in a host function. This is not allowed with NVCC.
- Remove .clangd-file which was accidentally added in a previous PR.
Naraenda
added
project: rocrand
organization: streamhpc
NguyenNhuDi
approved these changes
Aug 12, 2025
Contributor
NguyenNhuDi
left a comment
NguyenNhuDi
left a comment
There was a problem hiding this comment.
lgtm, mci failure seems unrelated to these changes. Triggered a new build to see if issue persists
assistant-librarian Bot
pushed a commit
to ROCm/rocRAND
that referenced
this pull request
Aug 18, 2025
fix(rocrand): resolve issues with nvcc compilation - Resolves compilation issues when building with nvcc. - Resolve a bunch of instances where a __device__ function was used that was defined in a __host__ function. This is not allowed with NVCC. - Remove .clangd-file which was accidentally added in a previous PR.
amd-jnovotny
pushed a commit
to amd-jnovotny/rocm-libraries
that referenced
this pull request
Aug 26, 2025
amd-jnovotny
pushed a commit
to amd-jnovotny/rocm-libraries
that referenced
this pull request
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.