Skip to content

[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage for rocRAND (#409)#1038

Merged
vamovsik merged 6 commits into
release/rocm-rel-7.0from
zenguyen/NguyenNhuDi/rocrand-increase-code-coverage-cherry-pick-7.0
Aug 8, 2025
Merged

[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage for rocRAND (#409)#1038
vamovsik merged 6 commits into
release/rocm-rel-7.0from
zenguyen/NguyenNhuDi/rocrand-increase-code-coverage-cherry-pick-7.0

Conversation

@NguyenNhuDi
Copy link
Copy Markdown
Contributor

Re opening this cherry-pick PR from source to trigger CI. Original PR here (#759)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (79.74%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/rocm-rel-7.0    #1038   +/-   ##
=====================================================
  Coverage                 75.10%   75.10%           
=====================================================
  Files                       495      495           
  Lines                     44357    44357           
  Branches                   5686     5686           
=====================================================
  Hits                      33310    33310           
  Misses                     6839     6839           
  Partials                   4208     4208           
Flag Coverage Δ
rocRAND 52.06% <ø> (ø)
rocThrust 79.74% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sdquiring pushed a commit that referenced this pull request Aug 1, 2025
OpenMP cmake config support along with RPATH updates.

[ROCm/hipBLAS commit: fe3af3c]
xiaohuguo2023 pushed a commit to xiaohuguo2023/rocm-libraries that referenced this pull request Aug 3, 2025
@NguyenNhuDi NguyenNhuDi closed this Aug 5, 2025
@NguyenNhuDi NguyenNhuDi deleted the zenguyen/NguyenNhuDi/rocrand-increase-code-coverage-cherry-pick-7.0 branch August 5, 2025 15:26
@NguyenNhuDi NguyenNhuDi restored the zenguyen/NguyenNhuDi/rocrand-increase-code-coverage-cherry-pick-7.0 branch August 5, 2025 15:29
@NguyenNhuDi NguyenNhuDi reopened this Aug 5, 2025
@stanleytsang-amd stanleytsang-amd self-requested a review August 5, 2025 16:22
@umfranzw
Copy link
Copy Markdown
Contributor

umfranzw commented Aug 5, 2025

I noticed there is one file from .jenkins/ (projects/rocrand/.jenkins/static.groovy) that was not brought back - is that still needed here?

@NguyenNhuDi
Copy link
Copy Markdown
Contributor Author

Hi @umfranzwm, the rocrand .jenkins is suppose to be deleted. I just accidentally deleted the rocthrust .jenkins directory. In my PR #1037 for rocThrust I deleted the rocThrust .jenkins there

Copy link
Copy Markdown
Contributor

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

TorreZuk pushed a commit that referenced this pull request Aug 7, 2025
OpenMP cmake config support along with RPATH updates.
@vamovsik vamovsik merged commit d0b5f8e into release/rocm-rel-7.0 Aug 8, 2025
15 of 17 checks passed
@vamovsik vamovsik deleted the zenguyen/NguyenNhuDi/rocrand-increase-code-coverage-cherry-pick-7.0 branch August 8, 2025 18:29
assistant-librarian Bot pushed a commit to ROCm/rocRAND that referenced this pull request Aug 8, 2025
[rocRAND][Code Coverage][Cherry Pick] Increase Code Coverage
 for rocRAND (#409) (#1038)

Re opening this cherry-pick PR from source to trigger CI. Original PR
here (#759)
amd-jnovotny pushed a commit to amd-jnovotny/rocm-libraries that referenced this pull request Aug 26, 2025
…m#1043)

OpenMP cmake config support along with RPATH updates.

(cherry picked from commit fe3af3c)

Co-authored-by: estewart08 <ethan.stewart@amd.com>
(cherry picked from commit ad2e8cb)
amd-jnovotny pushed a commit to amd-jnovotny/rocm-libraries that referenced this pull request Aug 26, 2025
…m#1043)

OpenMP cmake config support along with RPATH updates.

(cherry picked from commit fe3af3c)

Co-authored-by: estewart08 <ethan.stewart@amd.com>
(cherry picked from commit 9440e77)


[ROCm/hipBLAS commit: 2e4857a]
amd-jnovotny pushed a commit to amd-jnovotny/rocm-libraries that referenced this pull request Aug 26, 2025
CP merge pull request ROCm#1038 from estewart08/openmp-cmake-config (ROCm#1043)
amd-jnovotny pushed a commit to amd-jnovotny/rocm-libraries that referenced this pull request Aug 26, 2025
CP merge pull request ROCm#1038 from estewart08/openmp-cmake-config (ROCm#1043)

[ROCm/hipBLAS commit: 8d7ecf9]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants