Skip to content

Add settable seed#96

Merged
neon60 merged 2 commits into
developfrom
settable_seed
Feb 28, 2020
Merged

Add settable seed#96
neon60 merged 2 commits into
developfrom
settable_seed

Conversation

@neon60
Copy link
Copy Markdown
Collaborator

@neon60 neon60 commented Feb 25, 2020

Add settable seed

Copy link
Copy Markdown
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have random and seeded tests with this PR?

@neon60
Copy link
Copy Markdown
Collaborator Author

neon60 commented Feb 26, 2020

Do we have random and seeded tests with this PR?

As you can see, we have two variables, which we can change. random_seeds_count for the random seeds and seeds for the settable seeds:
https://github.com/ROCmSoftwarePlatform/rocThrust/pull/96/files#diff-4d9f03509b854b4da554336a59d305abR21-R23

We run both during tests. Example:
https://github.com/ROCmSoftwarePlatform/rocThrust/pull/96/files#diff-c24b37945371f6baebd97fd2806bcdb8R359-R363

Added the missing readme update.

@neon60 neon60 merged commit b77da43 into develop Feb 28, 2020
ammallya pushed a commit that referenced this pull request Oct 28, 2025
Add settable seed

[ROCm/rocThrust commit: b77da43]
ammallya pushed a commit that referenced this pull request Oct 28, 2025
This avoids errors on Windows when rocThrust is compiled in Release
instead of Debug (the default).

Patch from ROCm/TheRock#389.

---
🔁 Imported from
[#540](#540)
🧑‍💻 Originally authored by @marbre

Co-authored-by: Scott <scott.todd0@gmail.com>
Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants