Forward CMAKE_BUILD_TYPE when building gtest.#540
Closed
marbre wants to merge 1 commit into
Closed
Conversation
This avoids `lld-link: error: /failifmismatch: mismatch detected for '_ITERATOR_DEBUG_LEVEL':` errors on Windows when rocThrust is compiled in Release instead of Debug (the default).
marbre
requested review from
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
Contributor
|
Closing the pull request in this repo. Please refer to the migrated pull request for updates. |
marbre
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 26, 2025
This avoids errors on Windows when rocThrust is compiled in Release instead of Debug (the default). Patch from ROCm/TheRock#389. --- 🔁 Imported from [ROCm/rocThrust#540](ROCm/rocThrust#540) 🧑💻 Originally authored by @marbre Co-authored-by: Scott <scott.todd0@gmail.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
This avoids errors on Windows when rocThrust is compiled in Release instead of Debug (the default). Patch from ROCm/TheRock#389. --- 🔁 Imported from [#540](#540) 🧑💻 Originally authored by @marbre Co-authored-by: Scott <scott.todd0@gmail.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids
lld-link: error: /failifmismatch: mismatch detected for '_ITERATOR_DEBUG_LEVEL':errors on Windows when rocThrust is compiled in Release instead of Debug (the default).Patch from ROCm/TheRock#389.