Skip to content

Update changelog for CCCL 2.7#559

Closed
matyas-streamhpc wants to merge 1 commit into
ROCm:developfrom
StreamHPC:cccl2.7-fix-changelog
Closed

Update changelog for CCCL 2.7#559
matyas-streamhpc wants to merge 1 commit into
ROCm:developfrom
StreamHPC:cccl2.7-fix-changelog

Conversation

@matyas-streamhpc
Copy link
Copy Markdown

@matyas-streamhpc matyas-streamhpc commented May 30, 2025

Update changelog based on comments in
#557 (review)

@matyas-streamhpc matyas-streamhpc requested a review from a team as a code owner May 30, 2025 12:51
Comment thread CHANGELOG.md
### Changed

* Updated the required version of Google Benchmark from 1.8.0 to 1.9.0.
* Drop `c++14` support for rocThrust.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hipCUB and rocPRIM have aligned to use this wording under Removed in the change log:

Suggested change
* Drop `c++14` support for rocThrust.
* Removed C++14 support, only C++17 is supported.

Comment thread CHANGELOG.md

* Updated the required version of Google Benchmark from 1.8.0 to 1.9.0.
* Drop `c++14` support for rocThrust.
* Renamed `cpp14_required.h` to `cpp_version_check.h`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is internal and transparent to the user, it should be omitted.

@matyas-streamhpc
Copy link
Copy Markdown
Author

No modifications are required, therefore the PR is closed without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants