Changes for CCCL 2.7#557
Closed
NB4444 wants to merge 2 commits into
Closed
Conversation
NB4444
requested review from
a team,
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
spolifroni-amd
requested changes
May 29, 2025
Contributor
spolifroni-amd
left a comment
spolifroni-amd
left a comment
There was a problem hiding this comment.
The changelog should align with the other primitives libraries, hipCUB and rocPRIM.
| ### Changed | ||
|
|
||
| * Updated the required version of Google Benchmark from 1.8.0 to 1.9.0. | ||
| * Drop `c++14` support for rocthrust. |
Contributor
There was a problem hiding this comment.
The min version of C++ that's now supported needs to be mentioned. I think hipCUB and rocPRIM already have this in their changelogs, so this should be identical to those.
|
|
||
| * Updated the required version of Google Benchmark from 1.8.0 to 1.9.0. | ||
| * Drop `c++14` support for rocthrust. | ||
| * Renamed `cpp14_required.h` to `cpp_version_check.h` |
Contributor
There was a problem hiding this comment.
I think I saw this in either hipCUB or rocPRIM as well but can't remember if it was removed because this change should be transparent to the user, or if it was kept in just in case.
Contributor
|
Closing the pull request in this repo. Please refer to the migrated pull request for updates. |
stanleytsang-amd
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
May 30, 2025
Most of the changes here are pulling in the commits from CCCL 2.7. With the fixes and workarounds attached to these commits. --- 🔁 Imported from [ROCm/rocThrust#557](ROCm/rocThrust#557) 🧑💻 Originally authored by @NB4444 --------- Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
jayhawk-commits
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 17, 2025
Most of the changes here are pulling in the commits from CCCL 2.7. With the fixes and workarounds attached to these commits. --- 🔁 Imported from [ROCm/rocThrust#557](ROCm/rocThrust#557) 🧑💻 Originally authored by @NB4444 --------- Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the changes here are pulling in the commits from CCCL 2.7. With the fixes and workarounds attached to these commits.