Skip to content

Commit

Permalink
Update comment regarding barrier gfx908 hack: revert scheduling regio…
Browse files Browse the repository at this point in the history
…n when llvm/llvm-project#109294 is fixed
  • Loading branch information
dhernandez0 committed Sep 25, 2024
1 parent e286b76 commit 8e213de
Showing 1 changed file with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,8 @@ struct LDSBarrierOpLowering : public ConvertOpToLLVMPattern<LDSBarrierOp> {
auto asmDialectAttr = LLVM::AsmDialectAttr::get(rewriter.getContext(),
LLVM::AsmDialect::AD_ATT);
Location loc = op->getLoc();
// Ensure the inlineAsm is guarded with a scheduling region
// So it will not interfere with backend compilation more than
// it needs.
// Revert scheduling region when
// https://github.com/llvm/llvm-project/issues/109294 is fixed
rewriter.create<amdgpu::SchedBarrierOp>(
loc, amdgpu::sched_barrier_opt_enum::none);
const char *asmStr =
Expand Down

0 comments on commit 8e213de

Please sign in to comment.