Skip to content

Adding missing packages to rocBLAS cmake files, dockerfiles, and install script#646

Merged
amdkila merged 2 commits into
ROCm:developfrom
amdkila:openmp
Aug 12, 2019
Merged

Adding missing packages to rocBLAS cmake files, dockerfiles, and install script#646
amdkila merged 2 commits into
ROCm:developfrom
amdkila:openmp

Conversation

@amdkila
Copy link
Copy Markdown
Contributor

@amdkila amdkila commented Aug 9, 2019 •
edited
Loading

  • rocBLAS develop branch is failing right now as it cannot find OpenMP
  • This PR adds libomp-dev for Ubuntu and libgomp for CentOS
  • Also adds llvm6.0 for Ubuntu and llvm7.0 for CentOS
  • There are some additional issues with OpenMP/pthreads that occur on CentOS, and some fixes are added in some of the CMake files to fix that
  • I had similar issues with PR Using Blis for test validation #621 and am applying similar changes to the develop branch .
  • Passed CI with Ubuntu jobs

@amdkila amdkila changed the title Adding OpenMP and pthreads to rocBLAS cmake files Adding OpenMP and pthread flags to rocBLAS cmake files Aug 9, 2019
@amdkila amdkila changed the title Adding OpenMP and pthread flags to rocBLAS cmake files Adding OpenMP to rocBLAS cmake files and install script Aug 9, 2019
@amdkila amdkila changed the title Adding OpenMP to rocBLAS cmake files and install script Adding OpenMP and llvm to rocBLAS cmake files and install script Aug 12, 2019
@amdkila amdkila changed the title Adding OpenMP and llvm to rocBLAS cmake files and install script Adding missing packages to rocBLAS cmake files and install script Aug 12, 2019
@amdkila amdkila changed the title Adding missing packages to rocBLAS cmake files and install script Adding missing packages to rocBLAS cmake files, dockerfiles, and install script Aug 12, 2019
@amdkila amdkila requested a review from sdquiring August 12, 2019 16:09
@saadrahim saadrahim self-requested a review August 12, 2019 16:25
amcamd
amcamd approved these changes Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@amcamd amcamd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saadrahim
saadrahim approved these changes Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@saadrahim saadrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to get Jenkins passing again.

@amdkila amdkila merged commit 5ecd412 into ROCm:develop Aug 12, 2019
@amdkila amdkila deleted the openmp branch August 12, 2019 16:29
mlse-lib-jenkins pushed a commit that referenced this pull request Apr 21, 2021
@amcamd
Merge pull request #646 from amcamd/cherry-pick_lld_to_master
364a603 
add target_link_libraries -ldl for linker switch from ld to lld (#637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amcamd amcamd amcamd approved these changes

@saadrahim saadrahim saadrahim approved these changes

@leekillough leekillough Awaiting requested review from leekillough

@sdquiring sdquiring Awaiting requested review from sdquiring

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amdkila @amcamd @saadrahim