add logic files for new sizes#637
Merged
Merged
Conversation
zaliu
suggested changes
Aug 6, 2019
Contributor
zaliu
left a comment
zaliu
left a comment
There was a problem hiding this comment.
Please replicate the changed logic files from asm_full/ to asm_ci/, as I indicated in a recent announcement. Thanks!
mlse-lib-jenkins
pushed a commit
that referenced
this pull request
Apr 20, 2021
* add target_link_option -ldl * use target_link_libraries for -ldl * remove -ldl for clients, keep it only for library
mlse-lib-jenkins
pushed a commit
that referenced
this pull request
Apr 21, 2021
* add target_link_option -ldl * use target_link_libraries for -ldl * remove -ldl for clients, keep it only for library
mlse-lib-jenkins
pushed a commit
that referenced
this pull request
Apr 21, 2021
add target_link_libraries -ldl for linker switch from ld to lld (#637)
zaliu
pushed a commit
that referenced
this pull request
Apr 30, 2021
* add target_link_option -ldl * use target_link_libraries for -ldl * remove -ldl for clients, keep it only for library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of proposed changes:
adding tuning files for the new sizes, for bert, dlrm, phantom, winograd.
We had meaningful performance gains for the bert, phantom and winograd sizes, 85% - 92% efficiencies for lager sizes.
the dlrm sizes were problematic due to the fact that the were smaller. so the performance gains were minimal at best, this was a first pass at the tuning, we may be able to get some more improvement with more iterations but there is a limit to how much we can get in these cases.
I excluded the smaller phantom sizes since many of those sizes since I found majority of those had no gains in this iteration and they had trivial efficiency (< 1%)