Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTOGENERATED] [release/2.4] FEAT:at least one of ROCM_HOME or CUDA_HOME must be None. #1815

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

rocm-mici
Copy link

Cherry-pick of #1814

This PR is a release/2.5-based version of
#1809

Copied description by @hj-wei from
#1809

> Hi all, I manually generating nvcc to bypass NVIDIA component
checks(Megatron-LM),
see
https://github.com/NVIDIA/Megatron-LM/blob/2da43ef4c1b9e76f03b7567360cf7390e877f1b6/megatron/legacy/fused_kernels/__init__.py#L57

> but it can lead to incorrect CUDA_HOME configurations. This can cause
initialization anomalies in downstream libraries like DeepSpeed
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jan 6, 2025

Jenkins build for b16281ccf50e952de4291947c0e7b0c55f78c149 commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd jithunnair-amd changed the title [AUTOGENERATED] [release/2.4] Cherry-pick PR-1814 [AUTOGENERATED] [release/2.4] FEAT:at least one of ROCM_HOME or CUDA_HOME must be None. Jan 6, 2025
@jithunnair-amd jithunnair-amd marked this pull request as ready for review January 6, 2025 17:03
@jithunnair-amd jithunnair-amd merged commit 55ada20 into release/2.4 Jan 6, 2025
1 check failed
@jithunnair-amd jithunnair-amd deleted the release/2.4_cherry-pick_pr-1814 branch January 6, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants