[release/2.5] FEAT:at least one of ROCM_HOME or CUDA_HOME must be None. #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
! cherry-pick --onto release/2.4 |
|
!cherry-pick --onto release/2.4 |
rocm-mici
pushed a commit
that referenced
this pull request
Jan 6, 2025
This PR is a release/2.5-based version of #1809 Copied description by @hj-wei from #1809 > Hi all, I manually generating nvcc to bypass NVIDIA component checks(Megatron-LM), see https://github.com/NVIDIA/Megatron-LM/blob/2da43ef4c1b9e76f03b7567360cf7390e877f1b6/megatron/legacy/fused_kernels/__init__.py#L57 > but it can lead to incorrect CUDA_HOME configurations. This can cause initialization anomalies in downstream libraries like DeepSpeed
|
Created branch release/2.4_cherry-pick_pr-1814 and #1815 |
jithunnair-amd
changed the title
jithunnair-amd
added a commit
that referenced
this pull request
Jan 6, 2025
…HOME must be None. (#1815) Cherry-pick of #1814 Co-authored-by: Jithun Nair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a release/2.5-based version of #1809
Copied description by @hj-wei from #1809