Skip to content

[Comgr] Fix memory leak in test. #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from
Nov 6, 2025
+15 −4
Merged

[Comgr] Fix memory leak in test. #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9bc190
[Comgr] Fix memory leak in test.
jofrn Oct 27, 2025
cc815fe
Add more memory leak test fixes
jofrn Oct 27, 2025
d82e84f
Add a memleak fix within unbundle test
jofrn Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions amd/comgr/test-lit/comgr-sources/unbundle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ int main(int argc, char *argv[]) {
amd_comgr_(destroy_action_info(DataAction));
amd_comgr_(destroy_data_set(OutputBitcode));
amd_comgr_(destroy_data_set(InputBundles));
free(BundleData);

return 0;
}
3 changes: 3 additions & 0 deletions amd/comgr/test/file_map.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ int main(int argc, char *argv[]) {
Status = amd_comgr_get_data(DataObject, &SliceLength, Slice);
checkError(Status, "amd_comgr_get_data");

Status = amd_comgr_release_data(DataObject);
checkError(Status, "amd_comgr_release_data");

if (SliceLength != Length - Offset) {
fail("File Slice Length incorrect");
}
Expand Down
11 changes: 7 additions & 4 deletions amd/comgr/test/map_elf_virtual_address_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,9 @@ int main(int argc, char *argv[]) {
}

// Test rocm 5.7 elf virtual address mapping
amd_comgr_data_t DataExec2;
Status = amd_comgr_action_data_get_data(
DataSetExec, AMD_COMGR_DATA_KIND_EXECUTABLE, 1, &DataExec);
DataSetExec, AMD_COMGR_DATA_KIND_EXECUTABLE, 1, &DataExec2);
ElfVirtualAddress = 0x60;
CodeObjectOffset = -1;
// phdr.p_vaddr: 0
Expand All @@ -161,7 +162,7 @@ int main(int argc, char *argv[]) {
// nobits = phdr.p_vaddr >= phdr.p_filesz
// slizesize = phdr.p_memsz - (elfVirtualAddress - phdr.p_vaddr);
Status = amd_comgr_map_elf_virtual_address_to_code_object_offset(
DataExec, ElfVirtualAddress, &CodeObjectOffset, &SliceSize, &Nobits);
DataExec2, ElfVirtualAddress, &CodeObjectOffset, &SliceSize, &Nobits);
checkError(Status, "amd_comgr_map_elf_virtual_address_to_code_object_offset");

if (CodeObjectOffset != 0x60 || Nobits != 0 || SliceSize != 0x860) {
Expand All @@ -184,7 +185,7 @@ int main(int argc, char *argv[]) {
// nobits = phdr.p_vaddr >= phdr.p_filesz
// slizesize = phdr.p_memsz - (elfVirtualAddress - phdr.p_vaddr);
Status = amd_comgr_map_elf_virtual_address_to_code_object_offset(
DataExec, ElfVirtualAddress, &CodeObjectOffset, &SliceSize, &Nobits);
DataExec2, ElfVirtualAddress, &CodeObjectOffset, &SliceSize, &Nobits);
checkError(Status, "amd_comgr_map_elf_virtual_address_to_code_object_offset");

if (CodeObjectOffset != 0xa00 || Nobits != 0 || SliceSize != 0x480) {
Expand All @@ -207,7 +208,7 @@ int main(int argc, char *argv[]) {
// nobits = phdr.p_vaddr >= phdr.p_filesz
// slizesize = phdr.p_memsz - (elfVirtualAddress - phdr.p_vaddr);
Status = amd_comgr_map_elf_virtual_address_to_code_object_offset(
DataExec, ElfVirtualAddress, &CodeObjectOffset, &SliceSize, &Nobits);
DataExec2, ElfVirtualAddress, &CodeObjectOffset, &SliceSize, &Nobits);
checkError(Status, "amd_comgr_map_elf_virtual_address_to_code_object_offset");

if (CodeObjectOffset != 0xe90 || Nobits != 0 || SliceSize != 0x60) {
Expand Down Expand Up @@ -238,6 +239,8 @@ int main(int argc, char *argv[]) {
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_release_data(DataExec);
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_release_data(DataExec2);
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_destroy_data_set(DataSetExec);
checkError(Status, "amd_comgr_destroy_data_set");
free(BufSource1);
Expand Down
4 changes: 4 additions & 0 deletions amd/comgr/test/name_expression_map_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,10 @@ int main(int argc, char *argv[]) {
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_release_data(DataExec);
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_release_data(DataExec2);
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_release_data(DataReloc2);
checkError(Status, "amd_comgr_release_data");
Status = amd_comgr_destroy_data_set(DataSetIn);
checkError(Status, "amd_comgr_destroy_data_set");
Status = amd_comgr_destroy_data_set(DataSetBc);
Expand Down