Repository navigation
Correct the 0.10.0 changelog after a claim-by-claim check - #588
Merged
Merged
Conversation
Every claim was checked against the code and the rocm-10.0.0 tag. Adds the larfg/larf device pointers and the hipfftGetProperty rank-1 break, narrows the Dsyevdx_bufferSize break to the one routine it affects, and corrects the test list, the typed-form coverage, the install layout, the license header and compiler flag entries, and the ROCTx history.
ROCTx accepts a NUL-terminated Fortran string again (#589). Calls to a <routine>_ specific with a variable where the C API takes a pointer no longer compile for 223 specifics; one public project does this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every claim of the 0.10.0 section was checked against the code and the
rocm-10.0.0tag. The breaking patterns were compiled against modules built from both.Additions:
rocsolver_?larfg/?larf(and_64) takealpha/tauas device pointers: a Fixed entry plus a pattern in the Breaking list. The_64part depends on the companion PR fix_larfg_64.hipfftGetPropertywith a rank-1 array no longer compiles. It is added to the Breaking list, which now has eight patterns.Corrections:
nev/lworkbreak only affectedhipsolverDsyevdx_bufferSize. The other precisions already took an integer, andnevis a host pointer.devInfo,nevand larfg fixes said to usec_locof a host integer. They now say to pass a device pointer.howmany_dimsand on array elements._ex/Exand generic sparse routines, the hipBLAS batchedrotand the HIP_sptgetters keeptype(c_ptr)only.iamin/ger/herk/hemmare tested in rocBLAS only andtrmmin hipBLAS only. Increments apply togemvonly.lib/<triplet>only applies when installing to/usr, and the location of the config shim is corrected.Set*.cmakefiles are an exception.-tp=hostfix concerns-DBUILD_NATIVE=ONbuilds, not Release builds.Also reflows the rocTX comment in
lib/CMakeLists.txt, which #587 left on a single 100-column line.Later commit: the ROCTx bullet now describes the Fortran-string form restored by #589 (merge #589 first), and a new Breaking bullet covers direct calls to the
<routine>_specifics (223 changed an argument totype(c_ptr), value; one public project, M-PSDNS, callshipGetDevice_/hipMemGetInfo_this way).