Repository navigation
Withhold _typed from rocsolver_?larfg_64 and rocsolver_?larf_64 - #587
Merged
Merged
Conversation
alpha and tau of rocsolver_?larfg, and alpha of rocsolver_?larf, are device scalars, so these routines have no _typed form. The _64 variants still had one, which passed rocSOLVER the host address of a Fortran variable. Regenerated with rocm-fortran 00f8f8b, which applies a routine's .devonly entry to its _64 and _v2 variants as it already did .argkinds.
They justified roctx's place in the AMD-only list and in the amdgcn link test by the _cstr wrappers of a CONTAINS block that hipfort_roctx no longer has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alphaandtauofrocsolver_?larfg, andalphaofrocsolver_?larf, are device scalars ("A scalar on the GPU" in rocSOLVER's documentation). Since #584 these routines have no_typedform. The_64variants still had one, which passed rocSOLVER the host address of a Fortran variable.The generator applied a routine's
.argkindsentry to its_64/_v2variants but not its.devonlyentry. This is fixed in rocm-fortran 00f8f8b, which adds a unit test, and this PR is the regeneration.The diff removes the 8
rocsolver_{s,d,c,z}larf{,g}_64_typedprocedures and their 8 rows insupported_api_rocsolver.md. Nothing else changes, symbol tests included.Checked: gfortran
-Wall -DUSE_ASSUMED_SHAPEand amdflang-pedantic -DUSE_ASSUMED_RANKcompile with 0 warnings. No test referenced the removed forms. The 398 rocm-fortran tests pass.A second commit drops two stale comments in
lib/CMakeLists.txt. They blamed roctx being AMD-only on_cstrwrappers thathipfort_roctxno longer has. Comments only; CMake configures as before.