[hipCUB] Fix oob_default bug for block_merge_sort.#479
Closed
NguyenNhuDi wants to merge 3 commits into
Closed
Conversation
NguyenNhuDi
requested review from
a team,
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
spolifroni-amd
previously approved these changes
May 2, 2025
Contributor
Author
|
I think this is causing issues for the WarpMergeSort. I will investigate this issue |
Contributor
Author
|
Fixed warp sort issue. |
Contributor
Author
|
@Naraenda Can I get your thoughts on this? Thanks! |
Contributor
|
Closing the pull request in this repo. Please refer to the migrated pull request for updates. |
stanleytsang-amd
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
May 30, 2025
This PR fixes an issue where if the `valid_items` and `oob_default` parameter was used, the invalid elements was not filled in with `oob_default`. --- 🔁 Imported from [ROCm/hipCUB#479](ROCm/hipCUB#479) 🧑💻 Originally authored by @NguyenNhuDi --------- Co-authored-by: NguyenNhuDi <dinguyennhu@gmail.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
danielsu-amd
pushed a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 17, 2025
This PR fixes an issue where if the `valid_items` and `oob_default` parameter was used, the invalid elements was not filled in with `oob_default`. --- 🔁 Imported from [ROCm/hipCUB#479](ROCm/hipCUB#479) 🧑💻 Originally authored by @NguyenNhuDi --------- Co-authored-by: NguyenNhuDi <dinguyennhu@gmail.com> Co-authored-by: assistant-librarian[bot] <assistant-librarian[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if the
valid_itemsandoob_defaultparameter was used, the invalid elements was not filled in withoob_default.