Repository navigation
Conversation
The device/device_copy.hpp header was missing from the main hipcub.hpp header file. This change just adds it back.
…y_function to prevent syntax error (ROCm#435) * removed ussage of std::unary/binary_function * updated changelog
If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
* Resolve "Add missing macros in HIPCUB API" * Resolve "Add AliasTemporaries function" * Added macro names to CHANGELOG
* these files aren't used. part of them is in What Is * changed 'integral' to 'integer' * Added installation files * Update README.md * changing the link * reworded what is and data type support * Update docs/install/hipCUB-prerequisites.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * Update docs/install/hipCUB-install-on-Windows.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * added link to cmake * uppercases. --------- Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> (cherry picked from commit 0c83055)
* Limit test_hipcub_device_radix_sort memory usage On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. This happens because of an issue that sometimes causes hipMalloc to return hipSuccess for some allocation requests that are too large. This prevents us from being able to reliably detect whether a data size is too large for the test. This change works around the problem for now by limiting the data sizes that used are used for the test. * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update test/hipcub/test_hipcub_device_radix_sort.hpp Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu>
NguyenNhuDi
requested review from
a team,
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
February 27, 2025 17:39
spolifroni-amd
previously approved these changes
Feb 27, 2025
Collaborator
|
Hi @ROCm/rocm-documentation team, would it be possible to take a peek at this one when you have the chance? We'd like to try to get it merged today or tomorrow if we can. |
lpaoletti
approved these changes
Apr 22, 2025
umfranzw
added a commit
that referenced
this pull request
Apr 28, 2025
* [hipCUB] Mergeback 6.4 changes (#466) * Include device_copy header (#433) The device/device_copy.hpp header was missing from the main hipcub.hpp header file. This change just adds it back. * [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435) * removed ussage of std::unary/binary_function * updated changelog * Enable CMake HIP language (#434) If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> * Add hipcub::AliasTemporaries and some macros (#438) * Resolve "Add missing macros in HIPCUB API" * Resolve "Add AliasTemporaries function" * Added macro names to CHANGELOG * Created installation section (#440) (#458) * these files aren't used. part of them is in What Is * changed 'integral' to 'integer' * Added installation files * Update README.md * changing the link * reworded what is and data type support * Update docs/install/hipCUB-prerequisites.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * Update docs/install/hipCUB-install-on-Windows.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * added link to cmake * uppercases. --------- Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> (cherry picked from commit 0c83055) * Limit test_hipcub_device_radix_sort memory usage (#454) * Limit test_hipcub_device_radix_sort memory usage On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. This happens because of an issue that sometimes causes hipMalloc to return hipSuccess for some allocation requests that are too large. This prevents us from being able to reliably detect whether a data size is too large for the test. This change works around the problem for now by limiting the data sizes that used are used for the test. * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update test/hipcub/test_hipcub_device_radix_sort.hpp Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> * Update version number for ROCm 6.5.0 release (#477) This change updated the hipCUB version number to 3.5.0. It also removes the "(unreleased)" note from the changelog heading for this release. --------- Co-authored-by: Di Nguyen <dinguyennhu@gmail.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu>
umfranzw
added a commit
that referenced
this pull request
May 2, 2025
* [hipCUB] Mergeback 6.4 changes (#466) * Include device_copy header (#433) The device/device_copy.hpp header was missing from the main hipcub.hpp header file. This change just adds it back. * [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435) * removed ussage of std::unary/binary_function * updated changelog * Enable CMake HIP language (#434) If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> * Add hipcub::AliasTemporaries and some macros (#438) * Resolve "Add missing macros in HIPCUB API" * Resolve "Add AliasTemporaries function" * Added macro names to CHANGELOG * Created installation section (#440) (#458) * these files aren't used. part of them is in What Is * changed 'integral' to 'integer' * Added installation files * Update README.md * changing the link * reworded what is and data type support * Update docs/install/hipCUB-prerequisites.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * Update docs/install/hipCUB-install-on-Windows.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * added link to cmake * uppercases. --------- Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> (cherry picked from commit 0c83055) * Limit test_hipcub_device_radix_sort memory usage (#454) * Limit test_hipcub_device_radix_sort memory usage On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. This happens because of an issue that sometimes causes hipMalloc to return hipSuccess for some allocation requests that are too large. This prevents us from being able to reliably detect whether a data size is too large for the test. This change works around the problem for now by limiting the data sizes that used are used for the test. * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update test/hipcub/test_hipcub_device_radix_sort.hpp Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> * Update version number for ROCm 6.5.0 release (#477) This change updated the hipCUB version number to 3.5.0. It also removes the "(unreleased)" note from the changelog heading for this release. --------- Co-authored-by: Di Nguyen <dinguyennhu@gmail.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu>
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* [hipCUB] Mergeback 6.4 changes (#466) * Include device_copy header (#433) The device/device_copy.hpp header was missing from the main hipcub.hpp header file. This change just adds it back. * [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435) * removed ussage of std::unary/binary_function * updated changelog * Enable CMake HIP language (#434) If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> * Add hipcub::AliasTemporaries and some macros (#438) * Resolve "Add missing macros in HIPCUB API" * Resolve "Add AliasTemporaries function" * Added macro names to CHANGELOG * Created installation section (#440) (#458) * these files aren't used. part of them is in What Is * changed 'integral' to 'integer' * Added installation files * Update README.md * changing the link * reworded what is and data type support * Update docs/install/hipCUB-prerequisites.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * Update docs/install/hipCUB-install-on-Windows.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * added link to cmake * uppercases. --------- Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> (cherry picked from commit 51efcae) * Limit test_hipcub_device_radix_sort memory usage (#454) * Limit test_hipcub_device_radix_sort memory usage On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. This happens because of an issue that sometimes causes hipMalloc to return hipSuccess for some allocation requests that are too large. This prevents us from being able to reliably detect whether a data size is too large for the test. This change works around the problem for now by limiting the data sizes that used are used for the test. * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update test/hipcub/test_hipcub_device_radix_sort.hpp Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> * Update version number for ROCm 6.5.0 release (#477) This change updated the hipCUB version number to 3.5.0. It also removes the "(unreleased)" note from the changelog heading for this release. --------- Co-authored-by: Di Nguyen <dinguyennhu@gmail.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> [ROCm/hipCUB commit: 9930632]
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
* [hipCUB] Mergeback 6.4 changes (#466) * Include device_copy header (#433) The device/device_copy.hpp header was missing from the main hipcub.hpp header file. This change just adds it back. * [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435) * removed ussage of std::unary/binary_function * updated changelog * Enable CMake HIP language (#434) If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX. Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> * Add hipcub::AliasTemporaries and some macros (#438) * Resolve "Add missing macros in HIPCUB API" * Resolve "Add AliasTemporaries function" * Added macro names to CHANGELOG * Created installation section (#440) (#458) * these files aren't used. part of them is in What Is * changed 'integral' to 'integer' * Added installation files * Update README.md * changing the link * reworded what is and data type support * Update docs/install/hipCUB-prerequisites.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * Update docs/install/hipCUB-install-on-Windows.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * added link to cmake * uppercases. --------- Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> (cherry picked from commit 51efcae) * Limit test_hipcub_device_radix_sort memory usage (#454) * Limit test_hipcub_device_radix_sort memory usage On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an out of memory error on some devices. This happens because of an issue that sometimes causes hipMalloc to return hipSuccess for some allocation requests that are too large. This prevents us from being able to reliably detect whether a data size is too large for the test. This change works around the problem for now by limiting the data sizes that used are used for the test. * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update test/hipcub/test_hipcub_device_radix_sort.hpp Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> --------- Co-authored-by: Wayne Franz <wayfranz@amd.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> * Update version number for ROCm 6.5.0 release (#477) This change updated the hipCUB version number to 3.5.0. It also removes the "(unreleased)" note from the changelog heading for this release. --------- Co-authored-by: Di Nguyen <dinguyennhu@gmail.com> Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com> Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: Nara <naraenda@prasetya.eu> [ROCm/hipCUB commit: 040c29d]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.