Skip to content

Created installation section - #440

Merged
stanleytsang-amd merged 12 commits into
ROCm:developfrom
spolifroni-amd:spolifroni-amd/create-install-doc
Jan 21, 2025
Merged

stanleytsang-amd merged 12 commits into
ROCm:developfrom
spolifroni-amd:spolifroni-amd/create-install-doc

Conversation

@spolifroni-amd

@spolifroni-amd spolifroni-amd commented Dec 3, 2024 •

Copy link
Copy Markdown
Contributor

New installation section added. The change to the readme is the blurb at the top. I accidentally reused an old commit message.

Comment thread docs/install/hipCUB-prerequisites.rst Resolved
Comment thread docs/install/hipCUB-prerequisites.rst Resolved
spolifroni-amd and others added 4 commits December 18, 2024 11:24
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
@stanleytsang-amd
stanleytsang-amd merged commit 0c83055 into ROCm:develop Jan 21, 2025
spolifroni-amd added a commit to spolifroni-amd/hipCUB that referenced this pull request Feb 4, 2025
* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 0c83055)
stanleytsang-amd pushed a commit that referenced this pull request Feb 4, 2025
* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 0c83055)
umfranzw added a commit that referenced this pull request Apr 22, 2025
* Include device_copy header (#433)

The device/device_copy.hpp header was missing from the main hipcub.hpp
header file. This change just adds it back.

* [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435)

* removed ussage of std::unary/binary_function

* updated changelog

* Enable CMake HIP language (#434)

If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.

Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>

* Add hipcub::AliasTemporaries and some macros (#438)

* Resolve "Add missing macros in HIPCUB API"

* Resolve "Add AliasTemporaries function"

* Added macro names to CHANGELOG

* Created installation section (#440) (#458)

* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 0c83055)

* Limit test_hipcub_device_radix_sort memory usage (#454)

* Limit test_hipcub_device_radix_sort memory usage

On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an
out of memory error on some devices. This happens because of an issue
that sometimes causes hipMalloc to return hipSuccess for some allocation
requests that are too large. This prevents us from being able to
reliably detect whether a data size is too large for the test.

This change works around the problem for now by limiting the data sizes
that used are used for the test.

* Update CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update test/hipcub/test_hipcub_device_radix_sort.hpp

Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: Wayne Franz <wayfranz@amd.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>
umfranzw added a commit that referenced this pull request Apr 28, 2025
* [hipCUB] Mergeback 6.4 changes (#466)

* Include device_copy header (#433)

The device/device_copy.hpp header was missing from the main hipcub.hpp
header file. This change just adds it back.

* [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435)

* removed ussage of std::unary/binary_function

* updated changelog

* Enable CMake HIP language (#434)

If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.

Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>

* Add hipcub::AliasTemporaries and some macros (#438)

* Resolve "Add missing macros in HIPCUB API"

* Resolve "Add AliasTemporaries function"

* Added macro names to CHANGELOG

* Created installation section (#440) (#458)

* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 0c83055)

* Limit test_hipcub_device_radix_sort memory usage (#454)

* Limit test_hipcub_device_radix_sort memory usage

On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an
out of memory error on some devices. This happens because of an issue
that sometimes causes hipMalloc to return hipSuccess for some allocation
requests that are too large. This prevents us from being able to
reliably detect whether a data size is too large for the test.

This change works around the problem for now by limiting the data sizes
that used are used for the test.

* Update CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update test/hipcub/test_hipcub_device_radix_sort.hpp

Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: Wayne Franz <wayfranz@amd.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

* Update version number for ROCm 6.5.0 release (#477)

This change updated the hipCUB version number to 3.5.0.
It also removes the "(unreleased)" note from the changelog
heading for this release.

---------

Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>
umfranzw added a commit that referenced this pull request May 2, 2025
* [hipCUB] Mergeback 6.4 changes (#466)

* Include device_copy header (#433)

The device/device_copy.hpp header was missing from the main hipcub.hpp
header file. This change just adds it back.

* [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435)

* removed ussage of std::unary/binary_function

* updated changelog

* Enable CMake HIP language (#434)

If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.

Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>

* Add hipcub::AliasTemporaries and some macros (#438)

* Resolve "Add missing macros in HIPCUB API"

* Resolve "Add AliasTemporaries function"

* Added macro names to CHANGELOG

* Created installation section (#440) (#458)

* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 0c83055)

* Limit test_hipcub_device_radix_sort memory usage (#454)

* Limit test_hipcub_device_radix_sort memory usage

On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an
out of memory error on some devices. This happens because of an issue
that sometimes causes hipMalloc to return hipSuccess for some allocation
requests that are too large. This prevents us from being able to
reliably detect whether a data size is too large for the test.

This change works around the problem for now by limiting the data sizes
that used are used for the test.

* Update CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update test/hipcub/test_hipcub_device_radix_sort.hpp

Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: Wayne Franz <wayfranz@amd.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

* Update version number for ROCm 6.5.0 release (#477)

This change updated the hipCUB version number to 3.5.0.
It also removes the "(unreleased)" note from the changelog
heading for this release.

---------

Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>
ammallya pushed a commit that referenced this pull request Oct 28, 2025
* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

[ROCm/hipCUB commit: 0c83055]
ammallya pushed a commit that referenced this pull request Oct 28, 2025
* [hipCUB] Mergeback 6.4 changes (#466)

* Include device_copy header (#433)

The device/device_copy.hpp header was missing from the main hipcub.hpp
header file. This change just adds it back.

* [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435)

* removed ussage of std::unary/binary_function

* updated changelog

* Enable CMake HIP language (#434)

If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.

Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>

* Add hipcub::AliasTemporaries and some macros (#438)

* Resolve "Add missing macros in HIPCUB API"

* Resolve "Add AliasTemporaries function"

* Added macro names to CHANGELOG

* Created installation section (#440) (#458)

* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 51efcae)

* Limit test_hipcub_device_radix_sort memory usage (#454)

* Limit test_hipcub_device_radix_sort memory usage

On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an
out of memory error on some devices. This happens because of an issue
that sometimes causes hipMalloc to return hipSuccess for some allocation
requests that are too large. This prevents us from being able to
reliably detect whether a data size is too large for the test.

This change works around the problem for now by limiting the data sizes
that used are used for the test.

* Update CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update test/hipcub/test_hipcub_device_radix_sort.hpp

Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: Wayne Franz <wayfranz@amd.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

* Update version number for ROCm 6.5.0 release (#477)

This change updated the hipCUB version number to 3.5.0.
It also removes the "(unreleased)" note from the changelog
heading for this release.

---------

Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

[ROCm/hipCUB commit: 9930632]
ammallya pushed a commit that referenced this pull request Oct 28, 2025
* [hipCUB] Mergeback 6.4 changes (#466)

* Include device_copy header (#433)

The device/device_copy.hpp header was missing from the main hipcub.hpp
header file. This change just adds it back.

* [windows][hipCUB] Removed usage of std::unary_function and std::binary_function to prevent syntax error (#435)

* removed ussage of std::unary/binary_function

* updated changelog

* Enable CMake HIP language (#434)

If the HIP language can be used, the HIP_USECXX variable sets rocThrust to use the CMake HIP language rather than CXX.

Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>

* Add hipcub::AliasTemporaries and some macros (#438)

* Resolve "Add missing macros in HIPCUB API"

* Resolve "Add AliasTemporaries function"

* Added macro names to CHANGELOG

* Created installation section (#440) (#458)

* these files aren't used. part of them is in What Is

* changed 'integral' to 'integer'

* Added installation files

* Update README.md

* changing the link

* reworded what is and data type support

* Update docs/install/hipCUB-prerequisites.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* Update docs/install/hipCUB-install-on-Windows.rst

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>

* added link to cmake

* uppercases.

---------

Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
(cherry picked from commit 51efcae)

* Limit test_hipcub_device_radix_sort memory usage (#454)

* Limit test_hipcub_device_radix_sort memory usage

On Windows, HipcubDeviceRadixSort.SortKeysLargeSizes fails due to an
out of memory error on some devices. This happens because of an issue
that sometimes causes hipMalloc to return hipSuccess for some allocation
requests that are too large. This prevents us from being able to
reliably detect whether a data size is too large for the test.

This change works around the problem for now by limiting the data sizes
that used are used for the test.

* Update CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update test/hipcub/test_hipcub_device_radix_sort.hpp

Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

---------

Co-authored-by: Wayne Franz <wayfranz@amd.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

* Update version number for ROCm 6.5.0 release (#477)

This change updated the hipCUB version number to 3.5.0.
It also removes the "(unreleased)" note from the changelog
heading for this release.

---------

Co-authored-by: Di Nguyen <dinguyennhu@gmail.com>
Co-authored-by: Lauren Wrubleski <Lauren.Wrubleski@amd.com>
Co-authored-by: Nick Breed <78807921+NB4444@users.noreply.github.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: Nara <naraenda@prasetya.eu>

[ROCm/hipCUB commit: 040c29d]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs-only Skip most non-doc CI on this PR documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants