[A8W8 GEMM] Optimized weight-preshuffled implementation & add quantization datatype for CK TILE rms_norm#1862
Merged
Merged
Conversation
…leD epilogue optimization
Contributor
Author
|
Hi @illsilin |
afagaj
reviewed
Feb 10, 2025
Comment on lines
+274
to
+275
| // hipStream_t stream; | ||
| // hip_check_error(hipStreamCreate(&stream)); |
Collaborator
There was a problem hiding this comment.
Was this code meant to be uncommented?
Contributor
Author
There was a problem hiding this comment.
This code is a kind of explanatory note to whoever wondering why we use null hipStream in the ckProfiler kernel launch,
Co-authored-by: John Afaganis <john.afaganis@amd.com>
Contributor
|
Already add the 16x16 instances to the CK Profiler for pre-shuffle. |
aosewski
previously requested changes
Feb 20, 2025
Collaborator
aosewski
left a comment
aosewski
left a comment
There was a problem hiding this comment.
Are the changes to rmsnorm2d_rdquant relevant to this PR or is it a bad merge artifact?
ThomasNing
changed the title
Contributor
|
@aosewski It is a feature adding in this PR to add the quant data type for rmsnorm2d_rdquant ck_tile operator. |
illsilin
approved these changes
Feb 20, 2025
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered