Skip to content

[Block Scale GEMM] Optimized block scale gemm#1950

Merged
illsilin merged 36 commits into
developfrom
f8blockscale_opt
Mar 11, 2025
Merged

[Block Scale GEMM] Optimized block scale gemm#1950
illsilin merged 36 commits into
developfrom
f8blockscale_opt

Conversation

@aska-0096
Copy link
Copy Markdown
Contributor

Proposed changes

f8 blockscale gemm

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

This PR also addressed building time issue comes from #1862

@aska-0096 aska-0096 requested review from a team and asleepzzz as code owners March 6, 2025 07:50
@aska-0096 aska-0096 self-assigned this Mar 6, 2025
@aska-0096 aska-0096 added the enhancement New feature or request label Mar 6, 2025
Copy link
Copy Markdown
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like there's anything for docs, but if anything here needs to be communicated to the user, it should be added to the changelog.

@aska-0096 aska-0096 requested a review from tenpercent as a code owner March 7, 2025 02:04
@illsilin illsilin merged commit cbd74c2 into develop Mar 11, 2025
@illsilin illsilin deleted the f8blockscale_opt branch March 20, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants