Skip to content

[HIP] [JIT] [gfx950] Optimize Minimax M3 scoring & top-k kernels - #4787

Merged
valarLip merged 12 commits into
ROCm:mainfrom
ukannika:minimax_m3_sparse_attn_scoring_topk_kernels
Sep 1, 2026
Merged

[HIP] [JIT] [gfx950] Optimize Minimax M3 scoring & top-k kernels#4787
valarLip merged 12 commits into
ROCm:mainfrom
ukannika:minimax_m3_sparse_attn_scoring_topk_kernels

Conversation

@ukannika

Copy link
Copy Markdown
Contributor

Add fp8 MFMA sparse block scoring and top-k with fused page-table needed for pa gluon kernel.

@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests on MI35X (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:gfx1250-ffm-triton Run the five-shard gfx1250 FFM Triton test suite
ci:triton-300x Run an additional Triton test job on MI300X in PRs; main branch always runs both MI35X and MI300X
ci:sglang SGLang integration tests: DeepSeek-R1-MXFP4 accuracy, Qwen 3.5 accuracy
ci:atom ATOM benchmark: DeepSeek-R1-0528, GPT-OSS-120B
ci:atom_full ATOM accuracy suite for PR and main models from ATOM models_accuracy.json
ci:vllm vLLM benchmark: GPT-OSS-120B, DeepSeek-R1-0528, Kimi-K2.5
ci:all All standard extended tests (excludes ci:atom_full)

Only add ci:atom_full for FlyDSL or Triton upgrades.
Add labels via the sidebar or gh pr edit 4787 --add-label <label>

@ukannika
ukannika marked this pull request as ready for review August 23, 2026 02:44
@ukannika
ukannika requested a review from a team August 23, 2026 02:44
@github-actions github-actions Bot changed the title [gfx950] Optimize Minimax M3 scoring & top-k kernels [HIP] [JIT] [gfx950] Optimize Minimax M3 scoring & top-k kernels Aug 23, 2026
@zufayu
zufayu requested a review from amd-ruitang3 August 24, 2026 01:44
andyluo7 added a commit to andyluo7/vllm that referenced this pull request Aug 26, 2026
Integrate the AITER MiniMax M3 score and top-k kernels on the sparse paged-attention stack from vllm-project#52849, including the emitted sparse page table used by TP2/TP4.

Gate selection to the exact shapes compiled by ROCm/aiter#4787, preserve actionable FP8 fallback errors, and use the current keyword-only page-table API. Keep the AITER path ROCm-local so CUDA and other platforms retain their existing MSA/Triton selection.

Add focused selector, device-isolation, metadata, speculative-decode, mixed-batch, padding, and page-table parity coverage.

Depends-on: vllm-project#52849

Depends-on: ROCm/aiter#4787

Co-authored-by: Yamini Preethi Kamisetty <YaminiPreethi.Kamisetty@amd.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Andy Luo <andy.luo@amd.com>
@andyluo7

Copy link
Copy Markdown
Contributor

The current head cb3c7a628645 now has the full AITER test gate green, including all gfx950/MI35X shards and the final Aiter Test Gate. vLLM #52664 depends on these exact MiniMax-M3 score/top-k entry points; its focused current-head MI355X integration validation is queued now, and I will add the exact result when it completes.

Could an AITER maintainer please review #4787 for merge? This is the kernel dependency rather than a duplicate vLLM implementation.

andyluo7 added a commit to andyluo7/vllm that referenced this pull request Aug 26, 2026
Integrate the AITER MiniMax M3 score and top-k kernels on the sparse paged-attention stack from vllm-project#52849, including the emitted sparse page table used by TP2/TP4.

Gate selection to the exact shapes compiled by ROCm/aiter#4787, preserve actionable FP8 fallback errors, and use the current keyword-only page-table API. Keep the AITER path ROCm-local so CUDA and other platforms retain their existing MSA/Triton selection.

Add focused selector, device-isolation, metadata, speculative-decode, mixed-batch, padding, and page-table parity coverage.

Depends-on: vllm-project#52849

Depends-on: ROCm/aiter#4787

Co-authored-by: Yamini Preethi Kamisetty <YaminiPreethi.Kamisetty@amd.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: OpenAI Codex <codex@openai.com>
Signed-off-by: Andy Luo <andy.luo@amd.com>
Comment thread aiter/jit/optCompilerConfig.json Outdated
weitliao pushed a commit to weitliao/vllm that referenced this pull request Aug 31, 2026
Rebase onto vLLM vllm-project#52849 and apply final integration aligned with the
08_24 Docker image: AITER msa_attention indexer (ROCm/aiter#4787),
fused sparse page-table emit, and TP>1 support via emits_sparse_block_table.

Co-authored-by: Cursor <cursoragent@cursor.com>
@valarLip
valarLip merged commit fba53dc into ROCm:main Sep 1, 2026
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants