Skip to content

CI: Debug Aiter test issue #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyohuangxin merged 2 commits into from
Nov 26, 2025
Merged

CI: Debug Aiter test issue #1482

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea0c7ba
CI: Set MAX_JOBS=20 when running aiter tests
gyohuangxin Nov 26, 2025
420fb99
Update aiter-test.yaml
gyohuangxin Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/aiter-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
docker exec \
-w /workspace \
aiter_test \
./.github/scripts/aiter_test.sh
bash -c "MAX_JOBS=20 ./.github/scripts/aiter_test.sh"
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MAX_JOBS=20 environment variable is set for the standard tests but not for the multi-gpu tests (line 212). This creates an inconsistency where the two test jobs may behave differently during compilation.

Consider either:

  1. Adding MAX_JOBS=20 to the multi-gpu job as well for consistency, or
  2. Using the same syntax pattern (docker exec -e MAX_JOBS=20) in both jobs

Additionally, note that the multi-gpu job uses docker exec -e MULTIGPU=TRUE (line 209) which is a more standard way to pass environment variables to docker exec, while this change uses bash -c "MAX_JOBS=20 ..." which sets it within the bash command. The -e flag approach would be clearer and more consistent.

Copilot uses AI. Check for mistakes.

- name: Upload test logs
uses: actions/upload-artifact@v4
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
-e MULTIGPU=TRUE \
-w /workspace \
aiter_test \
./.github/scripts/aiter_test.sh
bash -c "MAX_JOBS=20 ./.github/scripts/aiter_test.sh"

- name: Upload test logs
uses: actions/upload-artifact@v4
Expand Down
Loading