Conversation
gyohuangxin
force-pushed
the
gyohuangxin-patch-7
branch
from
3889486 to
ea0c7ba
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to debug an issue with the Aiter tests by adding the MAX_JOBS=20 environment variable to limit parallel compilation jobs during test execution.
Key Changes:
- Modified the standard test job to set
MAX_JOBS=20when runningaiter_test.sh - Changed the execution from direct script invocation to using
bash -cwrapper
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -w /workspace \ | ||
| aiter_test \ | ||
| ./.github/scripts/aiter_test.sh | ||
| bash -c "MAX_JOBS=20 ./.github/scripts/aiter_test.sh" |
There was a problem hiding this comment.
The MAX_JOBS=20 environment variable is set for the standard tests but not for the multi-gpu tests (line 212). This creates an inconsistency where the two test jobs may behave differently during compilation.
Consider either:
- Adding
MAX_JOBS=20to the multi-gpu job as well for consistency, or - Using the same syntax pattern (
docker exec -e MAX_JOBS=20) in both jobs
Additionally, note that the multi-gpu job uses docker exec -e MULTIGPU=TRUE (line 209) which is a more standard way to pass environment variables to docker exec, while this change uses bash -c "MAX_JOBS=20 ..." which sets it within the bash command. The -e flag approach would be clearer and more consistent.
* CI: Set MAX_JOBS=20 when running aiter tests * Update aiter-test.yaml
* CI: Set MAX_JOBS=20 when running aiter tests * Update aiter-test.yaml
* CI: Set MAX_JOBS=20 when running aiter tests * Update aiter-test.yaml
* CI: Set MAX_JOBS=20 when running aiter tests * Update aiter-test.yaml
No description provided.