Add fused multimodal ROPE RMS for Qwen vision language models#1406
Merged
Add fused multimodal ROPE RMS for Qwen vision language models#1406
Conversation
This was referenced Nov 18, 2025
Collaborator
|
let me know once it's ready for review |
* add two * fix type error * add extra assert * add v as ret
Contributor
Author
|
@valarLip Ready for review |
farlukas
pushed a commit
that referenced
this pull request
Dec 4, 2025
Motivation Add mrope fused kernel for Qwen-vl models with inference mode. Technical Details For norm implementation details, we use warp norm method for better performance, overall uplift 10x compared with native torch ops.
nsusanto
pushed a commit
that referenced
this pull request
Dec 4, 2025
Motivation Add mrope fused kernel for Qwen-vl models with inference mode. Technical Details For norm implementation details, we use warp norm method for better performance, overall uplift 10x compared with native torch ops.
zhuyuhua-v
pushed a commit
that referenced
this pull request
Dec 17, 2025
Motivation Add mrope fused kernel for Qwen-vl models with inference mode. Technical Details For norm implementation details, we use warp norm method for better performance, overall uplift 10x compared with native torch ops.
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
Motivation Add mrope fused kernel for Qwen-vl models with inference mode. Technical Details For norm implementation details, we use warp norm method for better performance, overall uplift 10x compared with native torch ops.
valarLip
pushed a commit
that referenced
this pull request
Mar 18, 2026
Motivation Add mrope fused kernel for Qwen-vl models with inference mode. Technical Details For norm implementation details, we use warp norm method for better performance, overall uplift 10x compared with native torch ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add mrope fused kernel for Qwen-vl models with inference mode.
Technical Details
For norm implementation details, we use warp norm method for better performance, overall uplift 10x compared with native torch ops.
Tests
mrope qknorm fused 308 test (Qwen3-VL-235B-A22B-Instruct-FP8-dynamic)
before:
after: