[feat] mrotary embedding qknorm fused code#1427
Merged
xytpai merged 4 commits intoROCm:xyt/qknorm_mropefrom Nov 19, 2025
Merged
[feat] mrotary embedding qknorm fused code#1427xytpai merged 4 commits intoROCm:xyt/qknorm_mropefrom
xytpai merged 4 commits intoROCm:xyt/qknorm_mropefrom
Conversation
xytpai
added a commit
that referenced
this pull request
Nov 20, 2025
* add fused mrope rms * add op_tests/test_fused_mrope_rms.py * fix build errors * fix bugs * using load instead of nontemporal_load * fix lint * fix lint2 * fix lint2 * refine code * [feat] mrotary embedding qknorm fused code (#1427) * add two * fix type error * add extra assert * add v as ret * fix lint --------- Co-authored-by: Xin Huang <Xin.Huang@amd.com> Co-authored-by: ChenYou <youchen@amd.com>
xytpai
added a commit
to xytpai/aiter
that referenced
this pull request
Nov 20, 2025
* add fused mrope rms * add op_tests/test_fused_mrope_rms.py * fix build errors * fix bugs * using load instead of nontemporal_load * fix lint * fix lint2 * fix lint2 * refine code * [feat] mrotary embedding qknorm fused code (ROCm#1427) * add two * fix type error * add extra assert * add v as ret * fix lint --------- Co-authored-by: Xin Huang <Xin.Huang@amd.com> Co-authored-by: ChenYou <youchen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist