Skip to content

fix(profilers): fix rocprof-attach and add tests for rocpd and rocprofv3 executables #9509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yhuiYH merged 3 commits into from
Nov 2, 2026
Merged

fix(profilers): fix rocprof-attach and add tests for rocpd and rocprofv3 executables #9509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ab3dd
add profiler tests for rocpd and sdk executables
yhuiYH Oct 27, 2026
2e0c8e6
add rocprof-attach, which was accidentally excluded before, due to it…
yhuiYH Oct 27, 2026
72828c2
reduce comparison strings to check against
yhuiYH Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build_tools/build_python_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,9 @@ def run(args: argparse.Namespace):
# TODO: The base package is shoving CMake redirects into lib.
excludes=[
"**/cmake/**",
# profiler binaries
"bin/rocprof-*",
# profiler binaries (rocprof-attach from rocprofiler-sdk stays in core)
"bin/rocprof-compute*",
"bin/rocprof-sys-*",
# rocprofiler-systems payload
"include/rocprofiler-systems/**",
"lib/librocprof-sys*",
Expand Down
2 changes: 1 addition & 1 deletion build_tools/packaging/python/templates/rocm-sdk-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def import_dist_info():
"rocpd2pftrace=rocm_sdk_core._cli:rocpd2pftrace",
"rocpd2summary=rocm_sdk_core._cli:rocpd2summary",
"rocprofv3=rocm_sdk_core._cli:rocprofv3",
"rocprofv3-attach=rocm_sdk_core._cli:rocprofv3_attach",
"rocprof-attach=rocm_sdk_core._cli:rocprof_attach",
"rocprofv3-avail=rocm_sdk_core._cli:rocprofv3_avail",
]
if platform.system() != "Windows"
Expand Down
4 changes: 2 additions & 2 deletions build_tools/packaging/python/templates/rocm-sdk-core/src/rocm_sdk_core/_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,8 @@ def rocprofv3():
_exec("bin/rocprofv3")


def rocprofv3_attach():
_exec("bin/rocprofv3-attach")
def rocprof_attach():
_exec("bin/rocprof-attach")


def rocprofv3_avail():
Expand Down
8 changes: 8 additions & 0 deletions build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@
("rocminfo", [], "", True),
("rocm-smi", [], "Management", True),
("hipify-perl", ["--help"], "USAGE:", True),
("rocpd", ["--help"], "Aggregate", True),

@ScottTodd ScottTodd Oct 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand how this relates to #9535 "Fix ROCpd dependencies in Python wheels" ? The tool can run its --help but it has additional python requirements for full functionality?

Adding this test coverage is great, then I think we'll need to be careful about how to enable and test the rest if there are other python deps needed.

@yhuiYH yhuiYH Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the tool can run it's --help, but some sub-modules need additional python packages to fully use some features. The tool will instruct the user to install it by showing the instructions:

ImportError: pandas module not found. Please install it using 'pip install pandas' to export to other formats

I believe the author of #9535 is trying to solve that problem, to have the additional packages pre-installed.

("rocpd2csv", ["--help"], "Convert", True),
("rocpd2otf2", ["--help"], "Convert", True),
("rocpd2pftrace", ["--help"], "Convert", True),
("rocpd2summary", ["--help"], "Generate summary", True),
("rocprofv3", ["--help"], "ROCProfilerV3", True),
("rocprof-attach", ["--help"], "attachment", True),
("rocprofv3-avail", ["--help"], "query tool", True),
]

WINDOWS_CONSOLE_SCRIPT_TESTS = [
Expand Down
Loading