Repository navigation
fix(profilers): fix rocprof-attach and add tests for rocpd and rocprofv3 executables - #9509
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
therock-pr-bot
Bot
removed
the
Not ready to Review
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the profiler smoke tests and rocprof-attach packaging changes.
No open issues 🎉
What changed in this PR
This PR adds profiler command smoke tests to the ROCm Python packages and fixes the missing attach executable reported in #9545 by exposing and packaging rocprof-attach.
Changes:
- Add
--helpsmoke tests for eight rocpd and rocprofiler-sdk commands. - Rename the attach console entry point and launcher to
rocprof-attach. - Narrow packaging exclusions so
rocprof-attachremains in the core wheel.
| File | Description |
|---|---|
build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py |
Add profiler command smoke tests. |
build_tools/packaging/python/templates/rocm-sdk-core/src/rocm_sdk_core/_cli.py |
Launch the correct rocprof-attach executable. |
build_tools/packaging/python/templates/rocm-sdk-core/setup.py |
Register the rocprof-attach console entry point. |
build_tools/build_python_packages.py |
Retain the attach executable while excluding compute and systems profiler binaries. |
Review effort: Balanced
yhuiYH
changed the title
yhuiYH
changed the title
| ("rocminfo", [], "", True), | ||
| ("rocm-smi", [], "Management", True), | ||
| ("hipify-perl", ["--help"], "USAGE:", True), | ||
| ("rocpd", ["--help"], "Aggregate", True), |
There was a problem hiding this comment.
Can you help me understand how this relates to #9535 "Fix ROCpd dependencies in Python wheels" ? The tool can run its --help but it has additional python requirements for full functionality?
Adding this test coverage is great, then I think we'll need to be careful about how to enable and test the rest if there are other python deps needed.
There was a problem hiding this comment.
Yes, the tool can run it's --help, but some sub-modules need additional python packages to fully use some features. The tool will instruct the user to install it by showing the instructions:
ImportError: pandas module not found. Please install it using 'pip install pandas' to export to other formats
I believe the author of #9535 is trying to solve that problem, to have the additional packages pre-installed.
Motivation
Add rocpd and rocprofiler-sdk executable tests
Adding tests identified rocprof-attach issue.
Fixes: #9545
Technical Details
When these trampolines were added for
rocpd, the basic tests were not added for the executables. a8a4ba6Now, we should add and run these basic
--helpconsole tests to ensure the binaries run correctly.Immediately identified and fixes
rocprof-attachproblem:rocprof-attach, notrocprofv3-attachso it was being excluded whenbuild_python_packages.pywas runSource: https://github.com/ROCm/rocm-systems/blob/develop/projects/rocprofiler-sdk/source/bin/CMakeLists.txt#L27-L35
Test Plan
This PR adds tests
Test Result
Passing Python tests
Submission Checklist