ci: publish Windows MSIs to release buckets + dispatch install test (2/2)

.github/workflows/multi_arch_release.yml

@@ -198,6 +198,7 @@ jobs:
     with:
       build_config: ${{ needs.setup.outputs.windows_build_config }}
       rocm_package_version: ${{ needs.setup.outputs.rocm_package_version }}
+      rocm_msi_package_version: ${{ needs.setup.outputs.rocm_msi_package_version }}
       test_type: ${{ needs.setup.outputs.test_type }}
       release_type: ${{ inputs.release_type }}
       repository: ${{ inputs.repository || github.repository }}

.github/workflows/multi_arch_release_windows.yml

@@ -15,6 +15,8 @@ on:
         description: JSON object with build configuration for this platform.
       rocm_package_version:
         type: string
+      rocm_msi_package_version:
+        type: string
       test_type:
         type: string
       release_type:
@@ -124,8 +126,27 @@ jobs:
       contents: read
       id-token: write
 
+  build_native_msi_packages:
+    needs: [build_artifacts]
+    name: Build Native MSI Packages
+    uses: ./.github/workflows/multi_arch_build_native_windows_packages.yml
+    with:
+      artifact_run_id: ${{ github.run_id }}
+      rocm_version: ${{ inputs.rocm_package_version }}
+      msi_version: ${{ inputs.rocm_msi_package_version }}
+      # Only the runtime package is published in artifacts today; core's Windows
+      # artifacts (core-amdsmi, core-runtime) are not yet available.
+      packages: runtime
+      release_type: ${{ inputs.release_type }}
+      repository: ${{ inputs.repository }}
+      ref: ${{ inputs.ref }}
+      quartz_tracking_id: ${{ inputs.quartz_tracking_id }}
+    permissions:
+      contents: read
+      id-token: write
+
   publish_to_release_buckets:
-    needs: [build_tarballs, build_python_packages]
+    needs: [build_tarballs, build_python_packages, build_native_msi_packages]
     name: Publish to Release Buckets
     runs-on: ubuntu-26.04
     permissions:
@@ -197,6 +218,27 @@ jobs:
               "quartz_tracking_id": "${{ inputs.quartz_tracking_id }}"
             }
 
+  trigger_test_native_windows_install:
+    needs: [build_native_msi_packages]
+    name: Trigger Test Native Windows Packages Install
+    runs-on: ubuntu-26.04
+    permissions:
+      actions: write
+    steps:
+      - name: Trigger test_native_windows_packages_install
+        uses: benc-uk/workflow-dispatch@d004979be141727c7a17c28f603e2facc40d0855 # v1.3.3
+        with:
+          workflow: test_native_windows_packages_install.yml
+          inputs: |
+            { "artifact_run_id": "${{ github.run_id }}",
+              "packages": "runtime",
+              "rocm_version": "${{ inputs.rocm_package_version }}",
+              "release_type": "${{ inputs.release_type }}",
+              "run_uninstall": "true",
+              "repository": "${{ inputs.repository }}",
+              "ref": "${{ inputs.ref }}",
+              "quartz_tracking_id": "${{ inputs.quartz_tracking_id }}" }
+
   # The PyTorch release workflow publishes its wheels to the release index, then
   # tests from that index. Wait for the corresponding ROCm release to be published
   # before triggering the downstream release.
@@ -227,7 +269,7 @@ jobs:
 
   notify_quartz_completed:
     if: ${{ always() && vars.NOTIFY_QUARTZ_ENABLED == 'true' }}
-    needs: [build_artifacts, build_tarballs, build_python_packages, publish_to_release_buckets, trigger_test_artifacts_per_family, trigger_release_pytorch_wheels]
+    needs: [build_artifacts, build_tarballs, build_python_packages, build_native_msi_packages, publish_to_release_buckets, trigger_test_artifacts_per_family, trigger_release_pytorch_wheels, trigger_test_native_windows_install]
     name: "Quartz - completed - release Windows"
     runs-on: ubuntu-26.04
     timeout-minutes: 10

.github/workflows/test_native_windows_packages_install.yml

@@ -46,6 +46,13 @@ on:
         description: "Branch, tag, or SHA to checkout. Defaults to the triggering ref."
         type: string
         default: ""
+      quartz_tracking_id:
+        description: >-
+          Leave empty. Internal Quartz tracking id, set automatically by the
+          top-level orchestrator to link this run to its release lineage. Do not
+          set it manually.
+        type: string
+        default: ""
   workflow_call:
     inputs:
       artifact_run_id:
@@ -74,6 +81,9 @@ on:
       ref:
         type: string
         default: ""
+      quartz_tracking_id:
+        type: string
+        default: ""
 
 permissions:
   contents: read

build_tools/github_actions/publish_rocm_to_release_buckets.py

@@ -9,7 +9,7 @@
 - [x] tarballs
 - [x] python packages
 - [x] native linux packages
-- [ ] native windows packages
+- [x] native windows packages
 
 Example with ``--run-id 12345 --platform linux --release-type dev``:
 
@@ -43,6 +43,11 @@
     s3://therock-prerelease-artifacts/12345-linux/packages/rpm/
       -> s3://therock-repo-amd-rc-core/v5/rocm/core/packages/rpm/
 
+    native windows packages (dev/nightly), with ``--platform windows``:
+
+    s3://therock-dev-artifacts/12345-windows/packages/msi/
+      -> s3://therock-repo-amd-dev-core/v5/rocm/core/windows-installers/20250101-12345/
+
 ASAN build variant:
 
     For ASAN builds (--build-variant asan), python packages are skipped and
@@ -278,6 +283,49 @@ def publish_native_linux_packages(
             raise FileNotFoundError(f"No {pkg_type} packages found at {source.s3_uri}")
 
 
+def publish_native_windows_packages(
+    artifacts_root: WorkflowOutputRoot,
+    release_type: str,
+    backend: StorageBackend,
+) -> None:
+    """Copy native Windows MSI packages from the artifacts bucket to the release bucket.
+
+    The source MSIs were uploaded by upload_package_repo.py (called from
+    multi_arch_build_native_windows_packages.yml) as loose .msi files.
+
+    The destination follows RFC0012: Windows installer artifacts live under
+    ``core/windows-installers/`` (not ``core/packages/``). The current MSI is a
+    single OS-agnostic installer, so it is published to a flat
+    ``windows-installers/`` prefix rather than the per-OS subfolders RFC0012
+    reserves for OS-specific installers.
+
+    dev/nightly example:
+        s3://therock-dev-artifacts/12345-windows/packages/msi/
+          -> s3://therock-repo-amd-dev-core/v5/rocm/core/windows-installers/20250101-12345/
+
+    prerelease example:
+        s3://therock-prerelease-artifacts/12345-windows/packages/msi/
+          -> s3://therock-repo-amd-rc-core/v5/rocm/core/windows-installers/
+    """
+    dest_bucket = get_product_release_bucket_config(release_type, "core")
+    today = datetime.date.today().strftime("%Y%m%d")
+
+    source = artifacts_root.native_windows_packages("msi")
+
+    base_path = "v5/rocm/core/windows-installers"
+    if release_type == "prerelease":
+        dest_prefix = base_path
+    else:
+        dest_prefix = f"{base_path}/{today}-{artifacts_root.run_id}"
+
+    dest = StorageLocation(dest_bucket.name, dest_prefix)
+    logger.info("Native msi packages: %s -> %s", source.s3_uri, dest.s3_uri)
+    count = backend.copy_directory(source, dest)
+    logger.info("Copied %d files for msi packages", count)
+    if count == 0:
+        raise FileNotFoundError(f"No msi packages found at {source.s3_uri}")
+
+
 def main(argv: list[str]) -> None:
     parser = argparse.ArgumentParser(
         description="Publish ROCm release files to release buckets"
@@ -360,6 +408,8 @@ def main(argv: list[str]) -> None:
         publish_native_linux_packages(
             artifacts_root, args.release_type, backend, args.build_variant
         )
+    if artifacts_root.platform == "windows" and not args.skip_native_packages:
+        publish_native_windows_packages(artifacts_root, args.release_type, backend)
 
 
 if __name__ == "__main__":

build_tools/github_actions/tests/publish_rocm_to_release_buckets_test.py

@@ -133,7 +133,7 @@ def test_dev_linux_copies_native_packages(self, mock_copy):
         )
 
     @mock.patch("_therock_utils.storage_backend.S3StorageBackend.copy_directory")
-    def test_windows_skips_native_packages(self, mock_copy):
+    def test_windows_copies_native_msi_packages(self, mock_copy):
         mock_copy.return_value = 1
         main(
             [
@@ -146,8 +146,16 @@ def test_windows_skips_native_packages(self, mock_copy):
                 "--dry-run",
             ]
         )
-        # Only tarballs + python x2 (3 calls) — native packages skipped for windows
-        self.assertEqual(mock_copy.call_count, 3)
+        # Calls: tarballs, python x2, msi (4 calls)
+        self.assertEqual(mock_copy.call_count, 4)
+        # msi packages are the last call
+        msi_source, msi_dest = mock_copy.call_args_list[3].args
+        self.assertEqual(msi_source.bucket, "therock-nightly-artifacts")
+        self.assertEqual(msi_source.relative_path, "99-windows/packages/msi")
+        self.assertEqual(msi_dest.bucket, "therock-repo-amd-nightly-core")
+        self.assertRegex(
+            msi_dest.relative_path, r"^v5/rocm/core/windows-installers/\d{8}-99$"
+        )
 
     @mock.patch("_therock_utils.storage_backend.S3StorageBackend.copy_directory")
     def test_raises_when_no_tarballs_found(self, mock_copy):