Repository navigation
[ci] Reject conflicting CI build and skip labels - #9018
Merged
Merged
Conversation
Validate opposing labels for native Linux packages, ROCm Python packages, PyTorch, and JAX before job selection. Replace the previous build-label precedence test with input validation coverage. Validation: configuration tests passed (150 passed, 1 skipped). Generated with Codex
Move stage and test-label validation cases out of TestDecideJobs. Keep them focused on validate() rather than also running the configuration pipeline. Validation: configuration tests passed (150 passed, 1 skipped). Generated with Codex
ScottTodd
added
ci:build-jax
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
ScottTodd
added
ci:skip
ScottTodd
marked this pull request as ready for review
October 14, 2026 17:54
geomin12
approved these changes
Oct 14, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For #7346 I want to add a
ci:skip-rocmthat will conflict withci:build-python-packagesandci:build-native-linux, so this does some pre-work.This also moves some tests that were added under
TestDecideJobsincorrectly - if they testCIInputs.validate()they should go underTestCIInputs.Test Plan
Submission Checklist