Repository navigation
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
sa-faizal
changed the title
sa-faizal
marked this pull request as ready for review
October 7, 2026 04:23
Contributor
Author
|
This will prevent introduction of any compiler promotion related build failures also like LCOMPILER-2794 |
nunnikri
reviewed
Oct 7, 2026
sa-faizal
changed the title
ScottTodd
requested changes
Oct 8, 2026
sa-faizal
changed the title
ScottTodd
reviewed
Oct 8, 2026
geomin12
reviewed
Oct 8, 2026
Contributor
Author
|
Addressed the remaining review feedback in commit 0eeb302. Thank you! |
ScottTodd
reviewed
Oct 14, 2026
Comment on lines
+96
to
+98
| Sanitizer labels do not override GPU test gating. GPU sanity checks and | ||
| component tests remain subject to trigger and runner restrictions. CPU tests | ||
| may still run. `ci:skip` still skips CI. |
Member
There was a problem hiding this comment.
Unnecessary/confusing detail here (often seen with "low effort level" AI written docs). Please trim. This whole paragraph could just be deleted.
- The section is talking about submodule update pull requests. Why is
ci:skipmentioned at all here? - What is "CPU tests may still run" adding? That seems better suited for a section on GPU test labels, separate from automated submodule update PRs.
Comment on lines
1856
to
+1860
| # ASAN variant selection: | ||
| # 1. ci:asan label -> asan (explicit full ASAN, highest priority) | ||
| # 2. ci:host-asan label -> host-asan (explicit) | ||
| # 3. push/pull_request events -> host-asan (default for pre/postsubmit) | ||
| # 4. schedule/workflow_dispatch -> asan (nightly/manual get full ASAN) | ||
| # 1. ci:asan-debug label -> asan-debug (full ASAN with debug info) | ||
| # 2. ci:asan label -> asan (explicit full ASAN) | ||
| # 3. ci:host-asan-debug label -> host-asan-debug (host-only ASAN with debug info) | ||
| # 4. ci:host-asan label -> host-asan (explicit) |
Member
There was a problem hiding this comment.
I just merged #9018 which validates that some known labels conflicts are not present. Let's make it so only one ci:*asan label at a time can be added and if multiple are seen the CI fails. Then we won't need this priority list.
Comment on lines
-369
to
+377
| git = cm.GitContext( | ||
| changed_files=["CMakeLists.txt", "build_tools/script.py"], | ||
| ) | ||
| self.assertTrue(cm.should_skip_ci(inputs, git)) | ||
| for changed_files in ( | ||
| ["CMakeLists.txt", "build_tools/script.py"], | ||
| ["compiler/amd-llvm"], | ||
| ): | ||
| with self.subTest(changed_files=changed_files): | ||
| git = cm.GitContext( | ||
| changed_files=changed_files, submodule_paths=["compiler/amd-llvm"] | ||
| ) | ||
| self.assertTrue(cm.should_skip_ci(inputs, git)) |
Member
There was a problem hiding this comment.
Subtest is not useful here. All that matters is that CI is skipped when there are code changes and no asan label. We don't need to separately check CMakeLists.txt and build_tools/script.py as different types of code changes for that testing.
geomin12
approved these changes
Oct 14, 2026
geomin12
left a comment
geomin12
left a comment
Contributor
There was a problem hiding this comment.
lgtm. we can roll back if needed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Validate library and system submodule bumps with host-ASan builds, and let LLVM promotion PRs opt into full ASan builds with debug information.
ISSUE ID: #6624
Technical Details
ci:host-asanto library and system bump PRs.ci:asan-debugto select the existinglinux-release-asan-debugpreset for LLVM promotions or any other PR.ci:asan-debug, thenci:asan, thenci:host-asan. Removing sanitizer labels opts out;ci:skipstill skips CI.Test Plan
Check label selection, precedence, opt-out, and disabled GPU testing using CI configuration tests. Run bump automation tests and repository lint checks.
Test Result
Submission Checklist